Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 23478034: Do not add history entries for chrome-search:// urls. (Closed)

Created:
7 years, 3 months ago by Sergiu
Modified:
7 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Do not add history entries for chrome-search:// urls. We don't do it for chrome:// urls so I think we shouldn't either for chrome-search://. R=brettw@chromium.org BUG=286253 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/history/history_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergiu
Hey Brett, please take a look. Thanks.
7 years, 3 months ago (2013-09-13 08:59:33 UTC) #1
Sergiu
On 2013/09/13 08:59:33, Sergiu wrote: > Hey Brett, please take a look. Thanks. Ping :)
7 years, 3 months ago (2013-09-16 16:39:10 UTC) #2
brettw
lgtm
7 years, 3 months ago (2013-09-16 17:50:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiu@chromium.org/23478034/1
7 years, 3 months ago (2013-09-17 08:24:59 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 11:52:41 UTC) #5
Message was sent while issue was closed.
Change committed as 223581

Powered by Google App Engine
This is Rietveld 408576698