Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 23478023: Makes signing URL to respect --cloud-print-service flag. (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Makes signing URL to respect --cloud-print-service flag. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221587

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M chrome/browser/printing/cloud_print/cloud_print_url.cc View 1 2 3 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-05 19:05:59 UTC) #1
Noam Samuel
lgtm https://codereview.chromium.org/23478023/diff/3001/chrome/browser/printing/cloud_print/cloud_print_url.cc File chrome/browser/printing/cloud_print/cloud_print_url.cc (right): https://codereview.chromium.org/23478023/diff/3001/chrome/browser/printing/cloud_print/cloud_print_url.cc#newcode33 chrome/browser/printing/cloud_print/cloud_print_url.cc:33: const CommandLine& command_line = *CommandLine::ForCurrentProcess(); Maybe it's cleaner ...
7 years, 3 months ago (2013-09-05 19:35:35 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/23478023/diff/3001/chrome/browser/printing/cloud_print/cloud_print_url.cc File chrome/browser/printing/cloud_print/cloud_print_url.cc (right): https://codereview.chromium.org/23478023/diff/3001/chrome/browser/printing/cloud_print/cloud_print_url.cc#newcode33 chrome/browser/printing/cloud_print/cloud_print_url.cc:33: const CommandLine& command_line = *CommandLine::ForCurrentProcess(); On 2013/09/05 19:35:35, Noam ...
7 years, 3 months ago (2013-09-05 20:47:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23478023/9001
7 years, 3 months ago (2013-09-05 20:49:32 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 05:41:16 UTC) #5
Message was sent while issue was closed.
Change committed as 221587

Powered by Google App Engine
This is Rietveld 408576698