Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 23477079: Fix to allow ovals GM to finish on N7 (Closed)

Created:
7 years, 3 months ago by bsalomon
Modified:
7 years, 3 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix to allow ovals GM to finish on N7 Committed: http://code.google.com/p/skia/source/detail?r=11340

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +14 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLContext.h View 2 chunks +2 lines, -0 lines 2 comments Download
M src/gpu/gl/GrGLContext.cpp View 3 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
7 years, 3 months ago (2013-09-17 17:53:29 UTC) #1
jvanverth1
LGTM + comment https://codereview.chromium.org/23477079/diff/1/src/gpu/gl/GrGLContext.h File src/gpu/gl/GrGLContext.h (right): https://codereview.chromium.org/23477079/diff/1/src/gpu/gl/GrGLContext.h#newcode50 src/gpu/gl/GrGLContext.h:50: GrGLRenderer renderer() const { return fRenderer; ...
7 years, 3 months ago (2013-09-17 17:59:12 UTC) #2
bsalomon
https://codereview.chromium.org/23477079/diff/1/src/gpu/gl/GrGLContext.h File src/gpu/gl/GrGLContext.h (right): https://codereview.chromium.org/23477079/diff/1/src/gpu/gl/GrGLContext.h#newcode50 src/gpu/gl/GrGLContext.h:50: GrGLRenderer renderer() const { return fRenderer; } On 2013/09/17 ...
7 years, 3 months ago (2013-09-17 18:00:38 UTC) #3
robertphillips
Does this make it more pressing that we get the actual string from Chrome?
7 years, 3 months ago (2013-09-17 18:09:44 UTC) #4
bsalomon
On 2013/09/17 18:09:44, robertphillips wrote: > Does this make it more pressing that we get ...
7 years, 3 months ago (2013-09-17 18:17:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23477079/1
7 years, 3 months ago (2013-09-17 18:45:19 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 13:00:33 UTC) #7
Message was sent while issue was closed.
Change committed as 11340

Powered by Google App Engine
This is Rietveld 408576698