Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 23477050: Use an X event loop in the GPU process on Linux. (Closed)

Created:
7 years, 3 months ago by ccameron
Modified:
7 years, 3 months ago
Reviewers:
Nico, piman
CC:
chromium-reviews, sadrul, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Use an X event loop in the GPU process on Linux. In future patches, X windows will be created in the GPU process, and events sent to these windows will need to be forwarded to their parent windows. Linux uses GTK as the default UI event loop type, but GTK is not in the GPU process, so the X11 event loop type is used instead. BUG=145600 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222470

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M base/message_loop/message_loop.h View 5 chunks +19 lines, -1 line 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/message_loop/message_pump_x11.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M base/message_loop/message_pump_x11.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ccameron
This is the next step towards working around the NVIDIA X/GLX window bug. The step ...
7 years, 3 months ago (2013-09-10 08:07:01 UTC) #1
piman
lgtm
7 years, 3 months ago (2013-09-10 17:23:31 UTC) #2
Nico
lgtm https://codereview.chromium.org/23477050/diff/1/base/message_loop/message_pump_x11.h File base/message_loop/message_pump_x11.h (right): https://codereview.chromium.org/23477050/diff/1/base/message_loop/message_pump_x11.h#newcode46 base/message_loop/message_pump_x11.h:46: // Returns the UI message pump. comment now ...
7 years, 3 months ago (2013-09-10 17:29:40 UTC) #3
ccameron
Thanks!! https://codereview.chromium.org/23477050/diff/1/base/message_loop/message_pump_x11.h File base/message_loop/message_pump_x11.h (right): https://codereview.chromium.org/23477050/diff/1/base/message_loop/message_pump_x11.h#newcode46 base/message_loop/message_pump_x11.h:46: // Returns the UI message pump. On 2013/09/10 ...
7 years, 3 months ago (2013-09-10 18:03:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/23477050/1
7 years, 3 months ago (2013-09-10 18:06:26 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on linux_rel HTTP Error 400: Bad Request
7 years, 3 months ago (2013-09-10 18:07:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/23477050/2001
7 years, 3 months ago (2013-09-10 18:12:12 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=75918
7 years, 3 months ago (2013-09-10 21:49:10 UTC) #8
ccameron
That's a flake -- DenyingCameraDoesNotCauseStickyDenyForMics has been failing for ages. http://build.chromium.org/p/tryserver.chromium/builders/linux_aura
7 years, 3 months ago (2013-09-10 22:05:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/23477050/2001
7 years, 3 months ago (2013-09-11 00:21:55 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 04:20:07 UTC) #11
Message was sent while issue was closed.
Change committed as 222470

Powered by Google App Engine
This is Rietveld 408576698