Issue 23477042: Revert "Ignore should-scroll-on-main-thread if main frame is not scrollable"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23477042: Revert "Ignore should-scroll-on-main-thread if main frame is not scrollable" (Closed)

Created:
7 years, 3 months ago by Ian Vollick

Modified:
7 years, 3 months ago

Reviewers:
jamesr

CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Revert "Ignore should-scroll-on-main-thread if main frame is not scrollable" Turns out FrameView::isScrollable can sometimes crash. Reverting this change while I try and figure out why. This reverts commit 1a3edc542e31626a9b46ae2b18eb227c7031f3d6. TBR=jamesr@chromium.org BUG=280679 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157381

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -118 lines)			Patch
D	LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html	View	1 chunk	+0 lines, -112 lines	0 comments	Download
D	LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/23477042/1

7 years, 3 months ago (2013-09-06 16:46:41 UTC) #1

Message was sent while issue was closed.

Change committed as 157381