Show all Edit menu items when an app window is focused.

Show all Edit menu items when an app window is focused.

Based on feedback from UX, this shows all items in the Edit
menu when an app window is focused.
This copies the entire Edit menu instead of select items.

Some of the menu items don't work yet, we want to see how this feels on canary
and will iterate from there.

BUG=168080, 276052
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221153

[tapted, 2013-09-03 06:51:51]

lgtm.

Although the subject/CL first line description might confuse people. Maybe
mention it is for the menu shown for app windows there, and mention in the body
that this is based on feedback from UX.

[tapted, 2013-09-03 06:52:41]

+ chrome-apps-syd-reviews ;)

[jackhou1, 2013-09-03 09:05:20]

thakis, please review for OWNERS

[Nico, 2013-09-03 17:35:03]

https://codereview.chromium.org/23477029/diff/1/chrome/browser/ui/cocoa/apps/...
File chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm (right):

https://codereview.chromium.org/23477029/diff/1/chrome/browser/ui/cocoa/apps/...
chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm:111: // Edit menu.
This is copied entirely.
There's "Find->Search the web" which copies the omnibox. Does that make sense
for apps? What about "find next", does that work? spelling and grammar? speech?

[jackhou1, 2013-09-04 00:59:26]

https://codereview.chromium.org/23477029/diff/1/chrome/browser/ui/cocoa/apps/...
File chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm (right):

https://codereview.chromium.org/23477029/diff/1/chrome/browser/ui/cocoa/apps/...
chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm:111: // Edit menu.
This is copied entirely.
On 2013/09/03 17:35:03, Nico wrote:
> There's "Find->Search the web" which copies the omnibox. Does that make sense
> for apps? What about "find next", does that work? spelling and grammar?
speech?

"Search the web" opens up a Chrome window.
Find does not work, I'm not sure if it's just disabled, or infeasible.
Spelling and grammar work, but I think only on some HTML elements, e.g. it works
in Gmail but not Text. I think this is the same an in a tab.
Speech, which I assume does text to speech? behaves the same as in a tab, I get
no sound though, but I think it's my machine.
Dictation I haven't been able to test.
Special characters works.

I was advised by alcor@google.com (cc'd) that we should have all Edit menu items
if possible. I think it'd good to enable all of them for now so people can try
them on canary. It would make it easier to discuss which ones should be removed
or fixed. What do you think?

[Nico, 2013-09-04 01:01:42]

On 2013/09/04 00:59:26, jackhou1 wrote:
>
https://codereview.chromium.org/23477029/diff/1/chrome/browser/ui/cocoa/apps/...
> File chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm (right):
> 
>
https://codereview.chromium.org/23477029/diff/1/chrome/browser/ui/cocoa/apps/...
> chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm:111: // Edit
menu.
> This is copied entirely.
> On 2013/09/03 17:35:03, Nico wrote:
> > There's "Find->Search the web" which copies the omnibox. Does that make
sense
> > for apps? What about "find next", does that work? spelling and grammar?
> speech?
> 
> "Search the web" opens up a Chrome window.
> Find does not work, I'm not sure if it's just disabled, or infeasible.
> Spelling and grammar work, but I think only on some HTML elements, e.g. it
works
> in Gmail but not Text. I think this is the same an in a tab.
> Speech, which I assume does text to speech? behaves the same as in a tab, I
get
> no sound though, but I think it's my machine.
> Dictation I haven't been able to test.
> Special characters works.
> 
> I was advised by mailto:alcor@google.com (cc'd) that we should have all Edit
menu items
> if possible. I think it'd good to enable all of them for now so people can try
> them on canary. It would make it easier to discuss which ones should be
removed
> or fixed. What do you think?

If you make sure to get the menu doesn't stay in a weird state on dev for too
long, that's fine. The Cl description should say "some of the menu items don't
work yet, we want to see how this feels on canary and will iterate from there"
or similar. lgtm

[jackhou1, 2013-09-04 01:25:05]

On 2013/09/04 01:01:42, Nico wrote:
> On 2013/09/04 00:59:26, jackhou1 wrote:
> >
>
https://codereview.chromium.org/23477029/diff/1/chrome/browser/ui/cocoa/apps/...
> > File chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm (right):
> > 
> >
>
https://codereview.chromium.org/23477029/diff/1/chrome/browser/ui/cocoa/apps/...
> > chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm:111: // Edit
> menu.
> > This is copied entirely.
> > On 2013/09/03 17:35:03, Nico wrote:
> > > There's "Find->Search the web" which copies the omnibox. Does that make
> sense
> > > for apps? What about "find next", does that work? spelling and grammar?
> > speech?
> > 
> > "Search the web" opens up a Chrome window.
> > Find does not work, I'm not sure if it's just disabled, or infeasible.
> > Spelling and grammar work, but I think only on some HTML elements, e.g. it
> works
> > in Gmail but not Text. I think this is the same an in a tab.
> > Speech, which I assume does text to speech? behaves the same as in a tab, I
> get
> > no sound though, but I think it's my machine.
> > Dictation I haven't been able to test.
> > Special characters works.
> > 
> > I was advised by mailto:alcor@google.com (cc'd) that we should have all Edit
> menu items
> > if possible. I think it'd good to enable all of them for now so people can
try
> > them on canary. It would make it easier to discuss which ones should be
> removed
> > or fixed. What do you think?
> 
> If you make sure to get the menu doesn't stay in a weird state on dev for too
> long, that's fine. The Cl description should say "some of the menu items don't
> work yet, we want to see how this feels on canary and will iterate from there"
> or similar. lgtm

Done.

[commit-bot: I haz the power, 2013-09-04 01:26:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/23477029/1

[commit-bot: I haz the power, 2013-09-04 04:50:09]

Change committed as 221153