Issue 23477022: Two changes to desktop aura for tooltips:

Issue 23477022: Two changes to desktop aura for tooltips: (Closed)

Created:
7 years, 3 months ago by sky

Modified:
7 years, 3 months ago

Reviewers:
varunjain

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Two changes to desktop aura for tooltips: . Makes tooltip hide on exit. This is necessary on windows else we can leave tooltips on screen after an exit. . Changes desktop aura to only create a single TooltipController. This isn't strictly necessary, but better matches what we're doing on ash. BUG=275488 TEST=covered by test. R=varunjain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220432

Patch Set 1 #

Patch Set 2 : git add #

Total comments: 2

Patch Set 3 : 2013 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -14 lines)			Patch
M	ui/aura/test/event_generator.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/aura/test/event_generator.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	ui/views/corewm/tooltip_controller.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	ui/views/corewm/tooltip_controller_unittest.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	ui/views/views.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.h	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View		3 chunks	+4 lines, -11 lines	0 comments	Download
A	ui/views/widget/desktop_aura/scoped_tooltip_client.h	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
A	ui/views/widget/desktop_aura/scoped_tooltip_client.cc	View	1 2	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

varunjain

lgtm https://codereview.chromium.org/23477022/diff/3001/ui/views/widget/desktop_aura/scoped_tooltip_client.cc File ui/views/widget/desktop_aura/scoped_tooltip_client.cc (right): https://codereview.chromium.org/23477022/diff/3001/ui/views/widget/desktop_aura/scoped_tooltip_client.cc#newcode1 ui/views/widget/desktop_aura/scoped_tooltip_client.cc:1: // Copyright (c) 2012 The Chromium Authors. All ...

7 years, 3 months ago (2013-08-29 21:22:56 UTC) #2

sky

https://codereview.chromium.org/23477022/diff/3001/ui/views/widget/desktop_aura/scoped_tooltip_client.cc File ui/views/widget/desktop_aura/scoped_tooltip_client.cc (right): https://codereview.chromium.org/23477022/diff/3001/ui/views/widget/desktop_aura/scoped_tooltip_client.cc#newcode1 ui/views/widget/desktop_aura/scoped_tooltip_client.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights ...

7 years, 3 months ago (2013-08-29 21:27:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23477022/9001

7 years, 3 months ago (2013-08-29 21:30:06 UTC) #4

Message was sent while issue was closed.

Change committed as 220432

Expand Messages | Collapse Messages