Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 23477016: android: Wait for Chrome to finish writing trace file before downloading (Closed)

Created:
7 years, 3 months ago by Sami
Modified:
7 years, 3 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android: Wait for Chrome to finish writing trace file before downloading When downloading the latest trace file from Chrome, wait for Chrome to actually finish writing it to avoid getting back a partially written trace. Chrome logs two different messages related to tracing: 1. "Logging performance trace to file [...]" 2. "Profiler finished. Results are in [...]" The first one is printed when tracing starts and the second one indicates that the trace file is ready to be downloaded. We have to look for both of these messages to make sure we get the results from the latest trace and that the trace file is complete. This is done by first looking for the last instance of the first message and then checking for the second message in the remaining part of the log. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220298

Patch Set 1 #

Patch Set 2 : Wordsmithing #

Patch Set 3 : Simplify perl regex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M build/android/adb_profile_chrome View 1 2 2 chunks +39 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sami
PTAL. Maybe you know a neater way to do this.
7 years, 3 months ago (2013-08-29 10:44:54 UTC) #1
Torne
lgtm
7 years, 3 months ago (2013-08-29 12:23:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/23477016/2001
7 years, 3 months ago (2013-08-29 12:24:23 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 14:38:56 UTC) #4
Message was sent while issue was closed.
Change committed as 220298

Powered by Google App Engine
This is Rietveld 408576698