Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 23477012: my_activity: Add support for short URLs on gerrit. (Closed)

Created:
7 years, 3 months ago by deymo
Modified:
7 years, 3 months ago
Reviewers:
szager1, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

my_activity: Add support for short URLs on gerrit. Added support for the internal and external gerrit short URLs. BUG=None TEST=Ran my_activity.py manualy. URLs work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=220340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M my_activity.py View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
deymo
I think the gerrit host name should change as well, but the current one still ...
7 years, 3 months ago (2013-08-28 22:40:16 UTC) #1
deymo
maruel, can you take a look at this CL? Thanks.
7 years, 3 months ago (2013-08-29 17:58:12 UTC) #2
M-A Ruel
rubberstamp lgtm
7 years, 3 months ago (2013-08-29 18:03:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deymo@chromium.org/23477012/1
7 years, 3 months ago (2013-08-29 18:03:17 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 18:05:29 UTC) #5
Message was sent while issue was closed.
Change committed as 220340

Powered by Google App Engine
This is Rietveld 408576698