Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 23475049: Replace includes with forward declarations. (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Replace includes with forward declarations. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223355

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -81 lines) Patch
M chrome/browser/local_discovery/privet_http_asynchronous_factory.h View 1 1 chunk +19 lines, -47 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory.cc View 1 2 3 4 3 chunks +61 lines, -9 lines 2 comments Download
M chrome/browser/local_discovery/privet_notifications.h View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications_unittest.cc View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-14 22:26:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23475049/6001
7 years, 3 months ago (2013-09-14 22:26:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23475049/14001
7 years, 3 months ago (2013-09-14 22:35:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23475049/23001
7 years, 3 months ago (2013-09-16 05:00:42 UTC) #4
Noam Samuel
lgtm https://codereview.chromium.org/23475049/diff/23001/chrome/browser/local_discovery/privet_http_asynchronous_factory.cc File chrome/browser/local_discovery/privet_http_asynchronous_factory.cc (right): https://codereview.chromium.org/23475049/diff/23001/chrome/browser/local_discovery/privet_http_asynchronous_factory.cc#newcode86 chrome/browser/local_discovery/privet_http_asynchronous_factory.cc:86: return make_scoped_ptr<PrivetHTTPAsynchronousFactory>( What's the difference between make_scoped_ptr and ...
7 years, 3 months ago (2013-09-16 17:40:07 UTC) #5
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/23475049/diff/23001/chrome/browser/local_discovery/privet_http_asynchronous_factory.cc File chrome/browser/local_discovery/privet_http_asynchronous_factory.cc (right): https://codereview.chromium.org/23475049/diff/23001/chrome/browser/local_discovery/privet_http_asynchronous_factory.cc#newcode86 chrome/browser/local_discovery/privet_http_asynchronous_factory.cc:86: return make_scoped_ptr<PrivetHTTPAsynchronousFactory>( On 2013/09/16 17:40:07, Noam Samuel wrote: > ...
7 years, 3 months ago (2013-09-16 17:43:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23475049/23001
7 years, 3 months ago (2013-09-16 17:43:39 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 17:45:01 UTC) #8
Message was sent while issue was closed.
Change committed as 223355

Powered by Google App Engine
This is Rietveld 408576698