Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23475048: Fixes crashing in RequestUsbDevicesAccess (Closed)

Created:
7 years, 3 months ago by Bei Zhang
Modified:
7 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fixes crashing in RequestUsbDevicesAccess Pointer returned by vector::begin is not checked before use. BUG=291012, 288070 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223516

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M chrome/browser/extensions/api/usb/usb_api.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/usb/usb_device.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/usb/usb_device.cc View 1 3 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Bei Zhang
Hi Sergey, Please review, Thanks, Bei
7 years, 3 months ago (2013-09-14 00:22:49 UTC) #1
Bei Zhang
Hi Xiyuan, Please take a look. Thanks, Bei
7 years, 3 months ago (2013-09-14 00:29:50 UTC) #2
xiyuan
https://codereview.chromium.org/23475048/diff/1/chrome/browser/extensions/api/usb/usb_api.cc File chrome/browser/extensions/api/usb/usb_api.cc (right): https://codereview.chromium.org/23475048/diff/1/chrome/browser/extensions/api/usb/usb_api.cc#newcode328 chrome/browser/extensions/api/usb/usb_api.cc:328: if (devices->begin() == devices->end()) { nit: Can we use ...
7 years, 3 months ago (2013-09-14 00:37:31 UTC) #3
Bei Zhang
https://codereview.chromium.org/23475048/diff/1/chrome/browser/extensions/api/usb/usb_api.cc File chrome/browser/extensions/api/usb/usb_api.cc (right): https://codereview.chromium.org/23475048/diff/1/chrome/browser/extensions/api/usb/usb_api.cc#newcode328 chrome/browser/extensions/api/usb/usb_api.cc:328: if (devices->begin() == devices->end()) { On 2013/09/14 00:37:31, xiyuan ...
7 years, 3 months ago (2013-09-14 06:05:58 UTC) #4
xiyuan
LGTM Sorry, I thought I have already stamped on it. :p
7 years, 3 months ago (2013-09-16 17:23:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/23475048/10001
7 years, 3 months ago (2013-09-16 17:24:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=198047
7 years, 3 months ago (2013-09-17 00:07:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/23475048/10001
7 years, 3 months ago (2013-09-17 00:52:41 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 02:15:09 UTC) #9
Message was sent while issue was closed. 
Change committed as 223516

Powered by Google App Engine
This is Rietveld 408576698