Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 23475019: The HTML parser should lazy attach. (Closed)

Created:
7 years, 3 months ago by ojan
Modified:
7 years, 3 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, Timothy Loh, dstockwell, dglazkov+blink, adamk+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

The HTML parser should lazy attach. The rebaselines are one of the following: -empty whitespace text node changes -changes in anonymous wrapper blocks that don't affect the resulting layout -existing race conditions that are exposed by lazy attaching. These are the ones we've deemed OK to land. Some detailed explanations: -fast/dom/tabindex-defaults.html: FAIL is because of FIXME inside HTMLElement::supportsFocus crbug.com/285335 -svg/custom/getsvgdocument.html: crbug.com/284734 BUG=276689 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157319

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebaseline a couple more tests that I missed #

Patch Set 3 : Merge CharacterData change. #

Patch Set 4 : merge properly #

Patch Set 5 : fix mac failures #

Patch Set 6 : moar whitespace text node rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -305 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 2 chunks +42 lines, -1 line 0 comments Download
M LayoutTests/editing/selection/click-on-head-margin-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-generated-content/before-content-continuation-chain-expected.txt View 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/positioned-overflow-scroll-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/iframe-shadow-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/tabindex-defaults-expected.txt View 3 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/radio/radio_checked_dynamic-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/sandboxed-iframe-autofocus-denied-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/loader/resource-request-callbacks-expected.txt View 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/ruby/ruby-base-merge-block-children-crash-expected.txt View 3 1 chunk +6 lines, -8 lines 0 comments Download
M LayoutTests/fast/spatial-navigation/snav-tiny-table-traversal-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-row-style-not-updated-with-after-content-expected.txt View 3 1 chunk +6 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/inspector/network/network-initiator-expected.txt View 1 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/formmove3-expected.txt View 3 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/http/tests/navigation/javascriptlink-frames-expected.txt View 1 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt View 3 1 chunk +63 lines, -33 lines 0 comments Download
M LayoutTests/platform/win/fast/dynamic/002-expected.txt View 3 1 chunk +3 lines, -4 lines 0 comments Download
M LayoutTests/platform/win/fast/dynamic/011-expected.txt View 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/basic-textareas-quirks-expected.txt View 3 1 chunk +90 lines, -48 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/input-align-image-expected.txt View 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/preserveFormDuringResidualStyle-expected.txt View 3 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/select/listbox-appearance-basic-expected.txt View 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/textarea-scroll-height-expected.txt View 3 1 chunk +39 lines, -24 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/textarea-scrollbar-expected.txt View 3 2 chunks +9 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/textarea-scrolled-type-expected.txt View 3 1 chunk +41 lines, -22 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/textarea-width-expected.txt View 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/invalid/001-expected.txt View 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/invalid/003-expected.txt View 3 3 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/platform/win/fast/invalid/004-expected.txt View 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/invalid/007-expected.txt View 3 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/invalid/019-expected.txt View 3 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt View 3 4 chunks +19 lines, -18 lines 0 comments Download
M LayoutTests/platform/win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt View 3 4 chunks +43 lines, -44 lines 0 comments Download
M LayoutTests/platform/win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt View 3 2 chunks +6 lines, -5 lines 0 comments Download
M LayoutTests/platform/win/fast/parser/open-comment-in-textarea-expected.txt View 3 1 chunk +4 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/getsvgdocument-expected.txt View 3 3 chunks +9 lines, -8 lines 0 comments Download
M LayoutTests/platform/win/tables/mozilla/bugs/bug113235-1-expected.txt View 3 23 chunks +33 lines, -31 lines 0 comments Download
M LayoutTests/platform/win/tables/mozilla/bugs/bug647-expected.txt View 3 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/tables/mozilla/other/wa_table_tr_align-expected.txt View 3 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/plugins/plugin-remove-readystatechange.html View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/CharacterData.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
ojan
7 years, 3 months ago (2013-09-04 18:36:42 UTC) #1
eseidel
lgtm I'm comfortable with these changes. https://codereview.chromium.org/23475019/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp File Source/core/html/parser/HTMLConstructionSite.cpp (left): https://codereview.chromium.org/23475019/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp#oldcode108 Source/core/html/parser/HTMLConstructionSite.cpp:108: insert(task, DeprecatedAttachNow); I ...
7 years, 3 months ago (2013-09-04 18:39:14 UTC) #2
ojan
https://codereview.chromium.org/23475019/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp File Source/core/html/parser/HTMLConstructionSite.cpp (left): https://codereview.chromium.org/23475019/diff/1/Source/core/html/parser/HTMLConstructionSite.cpp#oldcode108 Source/core/html/parser/HTMLConstructionSite.cpp:108: insert(task, DeprecatedAttachNow); On 2013/09/04 18:39:14, eseidel wrote: > I ...
7 years, 3 months ago (2013-09-04 18:43:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/23475019/1
7 years, 3 months ago (2013-09-04 18:44:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/23475019/1
7 years, 3 months ago (2013-09-04 19:28:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/23475019/18001
7 years, 3 months ago (2013-09-04 20:41:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/23475019/31001
7 years, 3 months ago (2013-09-04 22:47:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/23475019/37001
7 years, 3 months ago (2013-09-04 23:15:20 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=4033
7 years, 3 months ago (2013-09-05 02:22:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/23475019/47001
7 years, 3 months ago (2013-09-05 18:34:12 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 20:09:50 UTC) #11
Message was sent while issue was closed.
Change committed as 157319

Powered by Google App Engine
This is Rietveld 408576698