Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 23475018: Added cloud policy registration and fetch types for iOS. (Closed)

Created:
7 years, 3 months ago by Joao da Silva
Modified:
7 years, 3 months ago
CC:
chromium-reviews, dconnelly, tslo, Bin
Visibility:
Public.

Description

Added cloud policy registration and fetch types for iOS. The --fake-cloud-policy-type flag has also been enabled for iOS, for testing purposes. BUG=285084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M chrome/browser/policy/cloud/cloud_policy_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_constants.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/policy/proto/cloud/device_management_backend.proto View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
This doesn't add new behavior, just introduces the constants so that Raymond can also start ...
7 years, 3 months ago (2013-09-04 11:32:26 UTC) #1
Mattias Nissler (ping if slow)
LGTM
7 years, 3 months ago (2013-09-04 11:36:50 UTC) #2
tslo_google.com
LGTM On Wed, Sep 4, 2013 at 4:36 AM, <mnissler@chromium.org> wrote: > LGTM > > ...
7 years, 3 months ago (2013-09-04 18:29:34 UTC) #3
Bin
lgtm Raymond, Can you make the same change on the Google3 side?
7 years, 3 months ago (2013-09-05 01:13:31 UTC) #4
tslo_google.com
Yes I will. On Wed, Sep 4, 2013 at 6:13 PM, <binzhao@chromium.org> wrote: > lgtm ...
7 years, 3 months ago (2013-09-05 01:14:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/23475018/1
7 years, 3 months ago (2013-09-05 06:13:09 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 07:21:34 UTC) #7
Message was sent while issue was closed.
Change committed as 221359

Powered by Google App Engine
This is Rietveld 408576698