Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: ui/views/focus/focus_manager.h

Issue 23475012: Fixes focus traversal bug (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: OVERRIDE Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/focus/focus_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/focus/focus_manager.h
diff --git a/ui/views/focus/focus_manager.h b/ui/views/focus/focus_manager.h
index 6a17fc2bc1a00e8174cc637f787efecdf6ba9d53..be254133826232a308fb82e9992a5fa4da1c8273 100644
--- a/ui/views/focus/focus_manager.h
+++ b/ui/views/focus/focus_manager.h
@@ -308,8 +308,16 @@ class VIEWS_EXPORT FocusManager {
}
private:
- // Returns the next focusable view.
- View* GetNextFocusableView(View* starting_view, bool reverse, bool dont_loop);
+ // Returns the next focusable view. Traversal starts at |starting_view|. If
+ // |starting_view| is NULL |starting_widget| is consuled to determine which
+ // Widget to start from. See
+ // WidgetDelegate::ShouldAdvanceFocusToTopLevelWidget() for details. If both
+ // |starting_view| and |starting_widget| are NULL, traversal starts at
+ // |widget_|.
+ View* GetNextFocusableView(View* starting_view,
+ Widget* starting_widget,
+ bool reverse,
+ bool dont_loop);
// Returns the focusable view found in the FocusTraversable specified starting
// at the specified view. This traverses down along the FocusTraversable
« no previous file with comments | « no previous file | ui/views/focus/focus_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698