Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 23473003: Added GPU driver workaround for OSX multimonitor multisampling disabling (Closed)

Created:
7 years, 3 months ago by bajones
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, piman
Visibility:
Public.

Description

Added GPU driver workaround for OSX multimonitor multisampling disabling BUG=280905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220495

Patch Set 1 : Removed unnecessary change to public API #

Total comments: 2

Patch Set 2 : Moved workaround check to more sensible location. #

Total comments: 1

Patch Set 3 : Whitespace tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +12 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bajones
Please review. Thanks!
7 years, 3 months ago (2013-08-29 06:19:00 UTC) #1
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/23473003/diff/3001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/23473003/diff/3001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode246 content/browser/gpu/gpu_data_manager_impl_private.cc:246: displayCount != manager->GetDisplayCount()) { The workaround check needs to ...
7 years, 3 months ago (2013-08-29 19:28:00 UTC) #2
bajones
On 2013/08/29 19:28:00, Ken Russell wrote: > The check on the driver bug workaround should ...
7 years, 3 months ago (2013-08-29 20:22:25 UTC) #3
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/23473003/diff/8001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/23473003/diff/8001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode244 content/browser/gpu/gpu_data_manager_impl_private.cc:244: if(displayCount != manager->GetDisplayCount()) { Please undo this whitespace ...
7 years, 3 months ago (2013-08-29 21:05:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/23473003/13001
7 years, 3 months ago (2013-08-29 21:09:22 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 03:24:35 UTC) #6
Message was sent while issue was closed.
Change committed as 220495

Powered by Google App Engine
This is Rietveld 408576698