Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: chrome/common/child_process_logging_win.cc

Issue 23471007: Set active extension IDs for crash reports using the crash key logging system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/child_process_logging_posix.cc ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_win.cc
diff --git a/chrome/common/child_process_logging_win.cc b/chrome/common/child_process_logging_win.cc
index d64b66fd4f2c7f5c990aeb5e8d06184f390a593c..c94b3cc8f7657520c3962aa14201567dee9472fa 100644
--- a/chrome/common/child_process_logging_win.cc
+++ b/chrome/common/child_process_logging_win.cc
@@ -23,14 +23,6 @@ namespace {
typedef void (__cdecl *MainSetClientId)(const wchar_t*);
// exported in breakpad_win.cc:
-// void __declspec(dllexport) __cdecl SetNumberOfExtensions.
-typedef void (__cdecl *MainSetNumberOfExtensions)(int);
-
-// exported in breakpad_win.cc:
-// void __declspec(dllexport) __cdecl SetExtensionID.
-typedef void (__cdecl *MainSetExtensionID)(size_t, const wchar_t*);
-
-// exported in breakpad_win.cc:
// void __declspec(dllexport) __cdecl SetPrinterInfo.
typedef void (__cdecl *MainSetPrinterInfo)(const wchar_t*);
@@ -102,44 +94,6 @@ std::string GetClientId() {
return std::string();
}
-void SetActiveExtensions(const std::set<std::string>& extension_ids) {
- static MainSetNumberOfExtensions set_number_of_extensions = NULL;
- // note: benign race condition on set_number_of_extensions.
- if (!set_number_of_extensions) {
- HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName);
- if (!exe_module)
- return;
- set_number_of_extensions = reinterpret_cast<MainSetNumberOfExtensions>(
- GetProcAddress(exe_module, "SetNumberOfExtensions"));
- if (!set_number_of_extensions)
- return;
- }
-
- static MainSetExtensionID set_extension_id = NULL;
- // note: benign race condition on set_extension_id.
- if (!set_extension_id) {
- HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName);
- if (!exe_module)
- return;
- set_extension_id = reinterpret_cast<MainSetExtensionID>(
- GetProcAddress(exe_module, "SetExtensionID"));
- if (!set_extension_id)
- return;
- }
-
- (set_number_of_extensions)(static_cast<int>(extension_ids.size()));
-
- std::set<std::string>::const_iterator iter = extension_ids.begin();
- for (size_t i = 0; i < kMaxReportedActiveExtensions; ++i) {
- if (iter != extension_ids.end()) {
- (set_extension_id)(i, ASCIIToWide(iter->c_str()).c_str());
- ++iter;
- } else {
- (set_extension_id)(i, L"");
- }
- }
-}
-
void SetPrinterInfo(const char* printer_info) {
static MainSetPrinterInfo set_printer_info = NULL;
// note: benign race condition on set_printer_info.
« no previous file with comments | « chrome/common/child_process_logging_posix.cc ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698