Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: chrome/common/child_process_logging_mac.mm

Issue 23471007: Set active extension IDs for crash reports using the crash key logging system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/child_process_logging.h ('k') | chrome/common/child_process_logging_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_mac.mm
diff --git a/chrome/common/child_process_logging_mac.mm b/chrome/common/child_process_logging_mac.mm
index 50cbfdaa819369e8efcfc540210ad6fa725730eb..eac57dc66050b7e4606ebdd64c9c9368589a3a72 100644
--- a/chrome/common/child_process_logging_mac.mm
+++ b/chrome/common/child_process_logging_mac.mm
@@ -25,8 +25,6 @@ using base::debug::ClearCrashKey;
const char* kGuidParamName = "guid";
const char* kNumberOfViews = "num-views";
-const char* kNumExtensionsName = "num-extensions";
-const char* kExtensionNameFormat = "extension-%zu";
const char* kPrinterInfoNameFormat = "prn-info-%zu";
// Account for the terminating null character.
@@ -53,25 +51,6 @@ std::string GetClientId() {
return std::string(g_client_id);
}
-void SetActiveExtensions(const std::set<std::string>& extension_ids) {
- // Log the count separately to track heavy users.
- const int count = static_cast<int>(extension_ids.size());
- SetCrashKeyValue(kNumExtensionsName, base::IntToString(count));
-
- // Record up to |kMaxReportedActiveExtensions| extensions, clearing
- // keys if there aren't that many.
- std::set<std::string>::const_iterator iter = extension_ids.begin();
- for (size_t i = 0; i < kMaxReportedActiveExtensions; ++i) {
- std::string key = base::StringPrintf(kExtensionNameFormat, i);
- if (iter != extension_ids.end()) {
- SetCrashKeyValue(key, *iter);
- ++iter;
- } else {
- ClearCrashKey(key);
- }
- }
-}
-
void SetPrinterInfo(const char* printer_info) {
std::vector<std::string> info;
base::SplitString(printer_info, ';', &info);
« no previous file with comments | « chrome/common/child_process_logging.h ('k') | chrome/common/child_process_logging_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698