Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: chrome/app/breakpad_linux.cc

Issue 23471007: Set active extension IDs for crash reports using the crash key logging system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/crash_logging.h ('k') | chrome/app/breakpad_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/breakpad_linux.cc
diff --git a/chrome/app/breakpad_linux.cc b/chrome/app/breakpad_linux.cc
index f2c127d2a37263e5d8d850291ee82727841f7c81..2652738791a62f0c01d055f4bb190bd5df6109e4 100644
--- a/chrome/app/breakpad_linux.cc
+++ b/chrome/app/breakpad_linux.cc
@@ -1167,16 +1167,6 @@ void HandleCrashDump(const BreakpadInfo& info) {
// 3 \r\n
// BOUNDARY \r\n
//
- // zero or one:
- // Content-Disposition: form-data; name="num-extensions" \r\n \r\n
- // 5 \r\n
- // BOUNDARY \r\n
- //
- // zero to 10:
- // Content-Disposition: form-data; name="extension-1" \r\n \r\n
- // abcdefghijklmnopqrstuvwxyzabcdef \r\n
- // BOUNDARY \r\n
- //
// zero to 4:
// Content-Disposition: form-data; name="prn-info-1" \r\n \r\n
// abcdefghijklmnopqrstuvwxyzabcdef \r\n
@@ -1311,26 +1301,6 @@ void HandleCrashDump(const BreakpadInfo& info) {
writer.Flush();
}
- if (*child_process_logging::g_num_extensions) {
- writer.AddPairString("num-extensions",
- child_process_logging::g_num_extensions);
- writer.AddBoundary();
- writer.Flush();
- }
-
- unsigned extension_ids_len =
- my_strlen(child_process_logging::g_extension_ids);
- if (extension_ids_len) {
- static const char extension_msg[] = "extension-";
- static const unsigned kMaxExtensionsLen =
- kMaxReportedActiveExtensions * child_process_logging::kExtensionLen;
- writer.AddPairDataInChunks(extension_msg, sizeof(extension_msg) - 1,
- child_process_logging::g_extension_ids,
- std::min(extension_ids_len, kMaxExtensionsLen),
- child_process_logging::kExtensionLen,
- false /* Don't strip whitespace. */);
- }
-
unsigned printer_info_len =
my_strlen(child_process_logging::g_printer_info);
if (printer_info_len) {
« no previous file with comments | « base/debug/crash_logging.h ('k') | chrome/app/breakpad_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698