Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: chrome/browser/extensions/extension_service.cc

Issue 23471007: Set active extension IDs for crash reports using the crash key logging system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/breakpad_win.cc ('k') | chrome/common/child_process_logging.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_service.h" 5 #include "chrome/browser/extensions/extension_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <set> 9 #include <set>
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 #include "chrome/browser/extensions/pending_extension_manager.h" 60 #include "chrome/browser/extensions/pending_extension_manager.h"
61 #include "chrome/browser/extensions/permissions_updater.h" 61 #include "chrome/browser/extensions/permissions_updater.h"
62 #include "chrome/browser/extensions/unpacked_installer.h" 62 #include "chrome/browser/extensions/unpacked_installer.h"
63 #include "chrome/browser/extensions/update_observer.h" 63 #include "chrome/browser/extensions/update_observer.h"
64 #include "chrome/browser/extensions/updater/extension_updater.h" 64 #include "chrome/browser/extensions/updater/extension_updater.h"
65 #include "chrome/browser/profiles/profile.h" 65 #include "chrome/browser/profiles/profile.h"
66 #include "chrome/browser/profiles/profile_manager.h" 66 #include "chrome/browser/profiles/profile_manager.h"
67 #include "chrome/browser/ui/webui/favicon_source.h" 67 #include "chrome/browser/ui/webui/favicon_source.h"
68 #include "chrome/browser/ui/webui/ntp/thumbnail_source.h" 68 #include "chrome/browser/ui/webui/ntp/thumbnail_source.h"
69 #include "chrome/browser/ui/webui/theme_source.h" 69 #include "chrome/browser/ui/webui/theme_source.h"
70 #include "chrome/common/child_process_logging.h"
71 #include "chrome/common/chrome_switches.h" 70 #include "chrome/common/chrome_switches.h"
72 #include "chrome/common/chrome_version_info.h" 71 #include "chrome/common/chrome_version_info.h"
72 #include "chrome/common/crash_keys.h"
73 #include "chrome/common/extensions/background_info.h" 73 #include "chrome/common/extensions/background_info.h"
74 #include "chrome/common/extensions/extension.h" 74 #include "chrome/common/extensions/extension.h"
75 #include "chrome/common/extensions/extension_constants.h" 75 #include "chrome/common/extensions/extension_constants.h"
76 #include "chrome/common/extensions/extension_file_util.h" 76 #include "chrome/common/extensions/extension_file_util.h"
77 #include "chrome/common/extensions/extension_manifest_constants.h" 77 #include "chrome/common/extensions/extension_manifest_constants.h"
78 #include "chrome/common/extensions/extension_messages.h" 78 #include "chrome/common/extensions/extension_messages.h"
79 #include "chrome/common/extensions/feature_switch.h" 79 #include "chrome/common/extensions/feature_switch.h"
80 #include "chrome/common/extensions/features/feature_channel.h" 80 #include "chrome/common/extensions/features/feature_channel.h"
81 #include "chrome/common/extensions/incognito_handler.h" 81 #include "chrome/common/extensions/incognito_handler.h"
82 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h" 82 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
(...skipping 2225 matching lines...) Expand 10 before | Expand all | Expand 10 after
2308 2308
2309 void ExtensionService::UpdateActiveExtensionsInCrashReporter() { 2309 void ExtensionService::UpdateActiveExtensionsInCrashReporter() {
2310 std::set<std::string> extension_ids; 2310 std::set<std::string> extension_ids;
2311 for (ExtensionSet::const_iterator iter = extensions_.begin(); 2311 for (ExtensionSet::const_iterator iter = extensions_.begin();
2312 iter != extensions_.end(); ++iter) { 2312 iter != extensions_.end(); ++iter) {
2313 const Extension* extension = iter->get(); 2313 const Extension* extension = iter->get();
2314 if (!extension->is_theme() && extension->location() != Manifest::COMPONENT) 2314 if (!extension->is_theme() && extension->location() != Manifest::COMPONENT)
2315 extension_ids.insert(extension->id()); 2315 extension_ids.insert(extension->id());
2316 } 2316 }
2317 2317
2318 child_process_logging::SetActiveExtensions(extension_ids); 2318 crash_keys::SetActiveExtensions(extension_ids);
2319 } 2319 }
2320 2320
2321 ExtensionService::ImportStatus ExtensionService::SatisfyImports( 2321 ExtensionService::ImportStatus ExtensionService::SatisfyImports(
2322 const Extension* extension) { 2322 const Extension* extension) {
2323 ImportStatus status = IMPORT_STATUS_OK; 2323 ImportStatus status = IMPORT_STATUS_OK;
2324 std::vector<std::string> pending; 2324 std::vector<std::string> pending;
2325 // TODO(elijahtaylor): Message the user if there is a failure that is 2325 // TODO(elijahtaylor): Message the user if there is a failure that is
2326 // unrecoverable. 2326 // unrecoverable.
2327 if (SharedModuleInfo::ImportsModules(extension)) { 2327 if (SharedModuleInfo::ImportsModules(extension)) {
2328 const std::vector<SharedModuleInfo::ImportInfo>& imports = 2328 const std::vector<SharedModuleInfo::ImportInfo>& imports =
(...skipping 853 matching lines...) Expand 10 before | Expand all | Expand 10 after
3182 } 3182 }
3183 3183
3184 void ExtensionService::AddUpdateObserver(extensions::UpdateObserver* observer) { 3184 void ExtensionService::AddUpdateObserver(extensions::UpdateObserver* observer) {
3185 update_observers_.AddObserver(observer); 3185 update_observers_.AddObserver(observer);
3186 } 3186 }
3187 3187
3188 void ExtensionService::RemoveUpdateObserver( 3188 void ExtensionService::RemoveUpdateObserver(
3189 extensions::UpdateObserver* observer) { 3189 extensions::UpdateObserver* observer) {
3190 update_observers_.RemoveObserver(observer); 3190 update_observers_.RemoveObserver(observer);
3191 } 3191 }
OLDNEW
« no previous file with comments | « chrome/app/breakpad_win.cc ('k') | chrome/common/child_process_logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698