Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py

Issue 23470006: Output units with histogram results. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update unit tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/perf_tests_helper.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py
index 3a4cc5fc2cca98faf056840fc303181e6a34a124..657e149869f9b48cc8883080828671ec6e157a44 100644
--- a/tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py
@@ -254,13 +254,13 @@ class BuildbotPageMeasurementResultsTest(unittest.TestCase):
measurement_results = SummarySavingPageMeasurementResults()
measurement_results.WillMeasurePage(test_page_set.pages[0])
- measurement_results.Add('a', '',
+ measurement_results.Add('a', 'units',
'{"buckets": [{"low": 1, "high": 2, "count": 1}]}',
data_type='histogram')
measurement_results.DidMeasurePage()
measurement_results.WillMeasurePage(test_page_set.pages[1])
- measurement_results.Add('a', '',
+ measurement_results.Add('a', 'units',
'{"buckets": [{"low": 2, "high": 3, "count": 1}]}',
data_type='histogram')
measurement_results.DidMeasurePage()
@@ -269,9 +269,9 @@ class BuildbotPageMeasurementResultsTest(unittest.TestCase):
expected = [
'HISTOGRAM a_by_name: http___www.foo.com_= ' +
- '{"buckets": [{"low": 1, "high": 2, "count": 1}]}\n' +
- 'Avg a_by_name: 1.500000',
+ '{"buckets": [{"low": 1, "high": 2, "count": 1}]} units\n' +
+ 'Avg a_by_name: 1.500000units',
'HISTOGRAM a_by_name: http___www.bar.com_= ' +
- '{"buckets": [{"low": 2, "high": 3, "count": 1}]}\n' +
- 'Avg a_by_name: 2.500000']
+ '{"buckets": [{"low": 2, "high": 3, "count": 1}]} units\n' +
+ 'Avg a_by_name: 2.500000units']
self.assertEquals(measurement_results.results, expected)
« no previous file with comments | « build/android/pylib/perf_tests_helper.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698