Issue 23470003: Implemented a switch for bypassing platform verification consent UI.

Issue 23470003: Implemented a switch for bypassing platform verification consent UI. (Closed)

Created:
7 years, 3 months ago by Darren Krahn

Modified:
7 years, 3 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, nkostylev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, dkrahn+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implemented a switch for bypassing platform verification consent UI. UI for the consent prompt is not ready yet but we want a way to perform an end-to-end integration test. This allows the consent to be explicitly given on the command line. BUG=chromium:270316 TEST=unit, manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221747

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits fixed #

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/attestation/platform_verification_flow.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/attestation/platform_verification_flow.cc	View	1 2	4 chunks	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

LGTM w/ nits. https://chromiumcodereview-hr.appspot.com/23470003/diff/1/chrome/browser/chromeos/attestation/platform_verification_flow.cc File chrome/browser/chromeos/attestation/platform_verification_flow.cc (right): https://chromiumcodereview-hr.appspot.com/23470003/diff/1/chrome/browser/chromeos/attestation/platform_verification_flow.cc#newcode27 chrome/browser/chromeos/attestation/platform_verification_flow.cc:27: // TODO(dkrahn): Remove this when UI ...

7 years, 3 months ago (2013-09-06 13:40:21 UTC) #2

Darren Krahn

https://chromiumcodereview.appspot.com/23470003/diff/1/chrome/browser/chromeos/attestation/platform_verification_flow.cc File chrome/browser/chromeos/attestation/platform_verification_flow.cc (right): https://chromiumcodereview.appspot.com/23470003/diff/1/chrome/browser/chromeos/attestation/platform_verification_flow.cc#newcode27 chrome/browser/chromeos/attestation/platform_verification_flow.cc:27: // TODO(dkrahn): Remove this when UI has been implemented. ...

7 years, 3 months ago (2013-09-06 15:52:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkrahn@chromium.org/23470003/9001

7 years, 3 months ago (2013-09-06 16:38:47 UTC) #4

Message was sent while issue was closed.

Change committed as 221747

Expand Messages | Collapse Messages