Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8274)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 23467010: [chromedriver] Logging tweaks and fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_client_impl.cc ('k') | chrome/test/chromedriver/commands.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index c9970868fd3f401b8f15196d83be2ef245e150cb..9867d4b23bc9e89078414795c79eb1e0577eb429 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -278,6 +278,7 @@ Status LaunchDesktopChrome(
&user_data_dir,
&extension_dir));
for (size_t i = 0; i < extension_bg_pages.size(); ++i) {
+ VLOG(0) << "Waiting for extension bg page load: " << extension_bg_pages[i];
scoped_ptr<WebView> web_view;
Status status = chrome_desktop->WaitForPageToLoad(
extension_bg_pages[i], base::TimeDelta::FromSeconds(10), &web_view);
@@ -558,6 +559,8 @@ Status WritePrefsFile(
std::string prefs_str;
base::JSONWriter::Write(prefs, &prefs_str);
+ VLOG(0) << "Populating " << path.BaseName().value()
+ << " file: " << PrettyPrintValue(*prefs);
if (static_cast<int>(prefs_str.length()) != file_util::WriteFile(
path, prefs_str.c_str(), prefs_str.length())) {
return Status(kUnknownError, "failed to write prefs file");
« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_client_impl.cc ('k') | chrome/test/chromedriver/commands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698