Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 23465027: Fix string and descriptor array decoding in grokdump. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix string and descriptor array decoding in grokdump. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M tools/grokdump.py View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 3 months ago (2013-09-19 09:35:09 UTC) #1
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-09-19 09:37:02 UTC) #2
Toon Verwaest
7 years, 3 months ago (2013-09-19 09:37:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16818 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698