Issue 23465025: [Activity Log] Enable end to end tests for Mac OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23465025: [Activity Log] Enable end to end tests for Mac OS (Closed)

Created:
7 years, 3 months ago by karenlees

Modified:
7 years, 3 months ago

Reviewers:
felt

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable end to end tests for Mac OS. The timeouts should be fixed now the number of window.open calls have been reduced (https://chromiumcodereview.appspot.com/19014003/). Two tests are showing other errors on Mac - they have separate bugs and will be looked into separately. This change also: - adds ability to customize expected logging to a particular OS - disable a test for particular OS. - some minor cleanup to make things more readable BUG=245594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223379

Patch Set 1 #

Patch Set 2 : try api test #

Patch Set 3 : trying more updates #

Patch Set 4 : Add ability to customize to OS #

Patch Set 5 : Remove manifest file from change #

Patch Set 6 : final fixes before sending for review #

Patch Set 7 : Fix line over 80 chars #

Patch Set 8 : merge with chromeos enable #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -35 lines)			Patch
	M	chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/test/data/extensions/api_test/activity_log_private/test/test.js	View	1 2 3 4 5 6	12 chunks	+96 lines, -34 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karenlees

This enables the tests that are working ok so I can make sure the timeouts ...

7 years, 3 months ago (2013-09-15 21:21:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/karenlees@chromium.org/23465025/26001

7 years, 3 months ago (2013-09-16 13:05:33 UTC) #3

Message was sent while issue was closed.

Change committed as 223379

Expand Messages | Collapse Messages