Issue 23464052: Uint8ClampedList no longer inherits from Uint8List

Issue 23464052: Uint8ClampedList no longer inherits from Uint8List (Closed)

Created:
7 years, 3 months ago by Cutch

Modified:
7 years, 3 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org, siva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Uint8ClampedList no longer inherits from Uint8List Committed: https://code.google.com/p/dart/source/detail?r=27366

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -5 lines)			Patch
M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View	1	3 chunks	+18 lines, -3 lines	0 comments	Download
M	sdk/lib/typed_data/typed_data.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/lib/typed_data/typed_data_hierarchy_int64_test.dart	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	tests/lib/typed_data/typed_data_hierarchy_test.dart	View		1 chunk	+52 lines, -0 lines	0 comments	Download
M	tests/standalone/typed_data_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

https://chromiumcodereview.appspot.com/23464052/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://chromiumcodereview.appspot.com/23464052/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode583 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:583: // final int length; This needs to be defined ...

7 years, 3 months ago (2013-09-10 18:35:54 UTC) #2

Cutch

Committed patchset #2 manually as r27366 (presubmit successful).

7 years, 3 months ago (2013-09-11 08:07:00 UTC) #3

Cutch

7 years, 3 months ago (2013-09-11 08:07:15 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23464052/diff/1/sdk/lib/typed_data/dart2js/ty...
File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right):

https://codereview.chromium.org/23464052/diff/1/sdk/lib/typed_data/dart2js/ty...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:583: // final int length;
On 2013/09/10 18:35:54, sra1 wrote:
> This needs to be defined like in Uint8List.

Done.

https://codereview.chromium.org/23464052/diff/1/sdk/lib/typed_data/dart2js/ty...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:664: class _Uint8ListSubclass
extends Uint8List native "Bogus Uint8List subclass" {
On 2013/09/10 18:35:54, sra1 wrote:
> Change the string to be an identifier:
> native "Uint8Array_bogus_subclass"

Done.

https://codereview.chromium.org/23464052/diff/1/sdk/lib/typed_data/dart2js/ty...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:671: }
On 2013/09/10 18:35:54, sra1 wrote:
> Add:
> 
>   // Factory constructor is unused but needed since a default
>   // (generative) constructor can't be generated for a class
>   // extending a class with no generative constructor.
>   factory _Uint8ListSubclass() => null;

Done.

Expand Messages | Collapse Messages