Issue 23464037: Net: make IsSafePortableRelativePath look for reserved names on all components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23464037: Net: make IsSafePortableRelativePath look for reserved names on all components. (Closed)

Created:
7 years, 3 months ago by rvargas (doing something else)

Modified:
7 years, 3 months ago

Reviewers:
asanka

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Net: make IsSafePortableRelativePath look for reserved names on all components. Now a reserved name is not allowed on any component of the path. BUG=none test=net_unittests R=asanka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221882

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -20 lines)			Patch
M	net/base/net_util.h	View	1	1 chunk	+6 lines, -9 lines	0 comments	Download
M	net/base/net_util.cc	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	net/base/net_util_unittest.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

asanka

lgtm https://codereview.chromium.org/23464037/diff/1/net/base/net_util.h File net/base/net_util.h (right): https://codereview.chromium.org/23464037/diff/1/net/base/net_util.h#newcode307 net/base/net_util.h:307: // * are valid path components, which: Nit: ...

7 years, 3 months ago (2013-09-06 21:19:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/23464037/8001

7 years, 3 months ago (2013-09-06 21:48:00 UTC) #3

Message was sent while issue was closed.

Change committed as 221882

Expand Messages | Collapse Messages