Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 23464033: Land Recent QUIC changes. (Closed)

Created:
7 years, 3 months ago by ramant (doing other things)
Modified:
7 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC changes. This is the first part of the code to allow faster stats/future compression stuff to register for a notification when a block of data has been fully ACKed by the peer. The idea is as follows: Someone who wants to be notified when their data is ACKed calls SendStreamDataAndNotifyWhenAcked instead of SendStreamData, and provides a Closure. The QuicConnection stores the Closure in a QuicAckNotifier, and maintains a vector of these. On every ACK frame received, the OnAck(acked_seqnums) method of each QuicAckNotifier is called. The QuicAckNotifier keeps track of the sequence numbers it is waiting to see, and after being notified of all of them it calls the Closure's Run() method. Merge internal change: 51476134 Changed SourceAddressToken's code not to include port number while performing crypto handshake (found in EndToEnd unit tests). Use IPAddressToPackedString for source address token comparison. Add CryptoServerConfig::set_strike_register_no_startup_period() to allow a QuicServer to start accepting 0-RTT handshakes without waiting a startup period. Add an end-to-end test for a successful 0-RTT handshake. Merge internal change: 51419595 Copying the overly-lenient SPDY workarounds to handling priority blocked streams for idle timeout logic. Merge internal change: 51406984 For this CL, the only chromium side change is to add QuicConnectionPeer::SetPeerAddress. Log packet retransmissions to DLOG(INFO). Use the standard format for the log messages for crypto handshake messages on the client side. Merge internal change: 51336227 New frame ID scheme to eliminate conflict between STREAM and PADDING frames. PADDING frames are now stream type 0. Description of the new scheme is in quic_framer.cc. Merge internal change: 51271708 Fixing a bug in implicitly created streams which results in early packet loss causing all streams to hang. Merge internal change: 51248632 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221419

Patch Set 1 #

Patch Set 2 : Merging with tip of the tree #

Patch Set 3 : fix compliation error #

Patch Set 4 : Fix valgrind error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1089 lines, -249 lines) Patch
M net/base/net_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/net.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config.cc View 6 chunks +12 lines, -2 lines 0 comments Download
M net/quic/crypto/source_address_token.cc View 1 chunk +19 lines, -7 lines 0 comments Download
A net/quic/quic_ack_notifier.h View 1 chunk +66 lines, -0 lines 0 comments Download
A net/quic/quic_ack_notifier.cc View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A net/quic/quic_ack_notifier_test.cc View 1 chunk +106 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 4 chunks +18 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 1 4 chunks +53 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 2 3 9 chunks +144 lines, -12 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_framer.cc View 7 chunks +269 lines, -81 lines 0 comments Download
M net/quic/quic_framer_test.cc View 47 chunks +115 lines, -110 lines 0 comments Download
M net/quic/quic_packet_creator.h View 2 chunks +12 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 4 chunks +32 lines, -3 lines 0 comments Download
M net/quic/quic_packet_generator.h View 3 chunks +16 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 4 chunks +18 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.h View 1 7 chunks +19 lines, -14 lines 0 comments Download
M net/quic/quic_protocol.cc View 6 chunks +23 lines, -1 line 0 comments Download
M net/quic/quic_session.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 7 chunks +17 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
ramant (doing other things)
7 years, 3 months ago (2013-09-04 19:42:42 UTC) #1
Ryan Hamilton
Please update the CL title to "Land Recent QUIC changes" LGTM since I have reviewed ...
7 years, 3 months ago (2013-09-04 19:44:24 UTC) #2
ramant (doing other things)
On 2013/09/04 19:44:24, Ryan Hamilton wrote: > Please update the CL title to "Land Recent ...
7 years, 3 months ago (2013-09-04 20:45:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23464033/6001
7 years, 3 months ago (2013-09-04 21:01:59 UTC) #4
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=10957
7 years, 3 months ago (2013-09-04 22:29:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23464033/36001
7 years, 3 months ago (2013-09-04 23:04:27 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-04 23:27:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23464033/49001
7 years, 3 months ago (2013-09-05 00:36:36 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82894
7 years, 3 months ago (2013-09-05 01:46:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23464033/49001
7 years, 3 months ago (2013-09-05 02:08:41 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82939
7 years, 3 months ago (2013-09-05 02:44:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23464033/49001
7 years, 3 months ago (2013-09-05 06:00:07 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83061
7 years, 3 months ago (2013-09-05 06:32:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23464033/49001
7 years, 3 months ago (2013-09-05 14:27:55 UTC) #14
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 14:30:23 UTC) #15
Message was sent while issue was closed.
Change committed as 221419

Powered by Google App Engine
This is Rietveld 408576698