Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java

Issue 23464023: Temporarily disable NavigationHistoryTest.testNavigateBackToNoncacheableLoginPage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable the test rather than change its caching policy Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
index 30c9a5647443e09ac29993b18909ee427a65a174..4fa8cad79a1b6b49df3827ac0f1454ac14603477 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
@@ -263,8 +263,16 @@ public class NavigationHistoryTest extends AwTestBase {
// and uses POST method for submission. It also contains a help link, leading
// to another page. We are verifying that it is possible to go back to the
// submitted login page after visiting the help page.
- @MediumTest
- @Feature({"AndroidWebView"})
+ /**
+ * Temporarily disabled. It is blocking a patch that fixes chromium's form
+ * resubmission defenses. This test should probably expect a modal dialog
+ * asking permission to re-post rather than expecting to just be able to navigate
+ * back to a page that specified Cache-Control: no-store.
+ *
+ * @MediumTest
+ * @Feature({"AndroidWebView"})
+ */
+ @DisabledTest
public void testNavigateBackToNoncacheableLoginPage() throws Throwable {
final TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHelper =
mContentsClient.getOnPageFinishedHelper();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698