Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 23464015: Default to binary encoding when loading MHTML files. (Closed)

Created:
7 years, 3 months ago by christiank
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Default to binary encoding when loading MHTML files. Assume binary encoding on MHTML files that doesn't have an encoding specified. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158022

Patch Set 1 #

Patch Set 2 : Added layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
A LayoutTests/mhtml/content_transfer_encoding_none.html_original View 1 Binary file 0 comments Download
A LayoutTests/mhtml/content_transfer_encoding_none.mht View 1 Binary file 0 comments Download
A + LayoutTests/mhtml/content_transfer_encoding_none-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/loader/archive/MHTMLParser.cpp View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
christiank
Adam, would you please have a look at this review? This is another patch related ...
7 years, 3 months ago (2013-08-28 12:49:57 UTC) #1
abarth-chromium
How does IE behave in this case? The code change itself looks fine assuming this ...
7 years, 3 months ago (2013-08-28 17:40:58 UTC) #2
christiank
On 2013/08/28 17:40:58, abarth wrote: > How does IE behave in this case? > > ...
7 years, 3 months ago (2013-08-29 09:23:55 UTC) #3
abarth-chromium
Great. LGTM. Let's land this together with the tests. I can try to do that ...
7 years, 3 months ago (2013-08-30 06:42:49 UTC) #4
christiank
On 2013/08/30 06:42:49, abarth wrote: > Great. LGTM. Let's land this together with the tests. ...
7 years, 3 months ago (2013-08-30 07:02:07 UTC) #5
christiank
On 2013/08/30 06:42:49, abarth wrote: > Great. LGTM. Let's land this together with the tests. ...
7 years, 3 months ago (2013-09-05 13:54:15 UTC) #6
abarth-chromium
On 2013/09/05 13:54:15, christiank wrote: > Any news? Did you have time to look at ...
7 years, 3 months ago (2013-09-16 14:17:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/christiank@opera.com/23464015/10001
7 years, 3 months ago (2013-09-19 08:32:16 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 09:33:13 UTC) #9
Message was sent while issue was closed.
Change committed as 158022

Powered by Google App Engine
This is Rietveld 408576698