Issue 23463033: Release password store on UI loop when worker is stopped so that password

Issue 23463033: Release password store on UI loop when worker is stopped so that password (Closed)

Created:
7 years, 3 months ago by haitaol1

Modified:
7 years, 3 months ago

Reviewers:
Nicolas Zea, zea%chromium.org

CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, kareng, Robert Sesek

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Release password store on UI loop when worker is stopped so that password service and thread can be shut down in proper order. BUG=274705 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223427

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
M	chrome/browser/sync/glue/password_model_worker.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/password_model_worker.cc	View		3 chunks	+22 lines, -5 lines	0 comments	Download
M	sync/internal_api/public/engine/model_safe_worker.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

lgtm https://codereview.chromium.org/23463033/diff/1/chrome/browser/sync/glue/password_model_worker.h File chrome/browser/sync/glue/password_model_worker.h (right): https://codereview.chromium.org/23463033/diff/1/chrome/browser/sync/glue/password_model_worker.h#newcode52 chrome/browser/sync/glue/password_model_worker.h:52: base::Lock password_store_lock_; Comment why a lock is needed ...

7 years, 3 months ago (2013-09-16 17:37:50 UTC) #2

haitaol1

https://codereview.chromium.org/23463033/diff/1/chrome/browser/sync/glue/password_model_worker.h File chrome/browser/sync/glue/password_model_worker.h (right): https://codereview.chromium.org/23463033/diff/1/chrome/browser/sync/glue/password_model_worker.h#newcode52 chrome/browser/sync/glue/password_model_worker.h:52: base::Lock password_store_lock_; On 2013/09/16 17:37:51, Nicolas Zea wrote: > ...

7 years, 3 months ago (2013-09-16 18:07:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/23463033/5001

7 years, 3 months ago (2013-09-16 18:10:13 UTC) #4

Message was sent while issue was closed.

Change committed as 223427

Expand Messages | Collapse Messages