Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 23463022: Enable CLD2 on Windows (Closed)

Created:
7 years, 3 months ago by hajimehoshi
Modified:
7 years, 3 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update CLD2 to r81 #

Patch Set 3 : (rebasing) #

Patch Set 4 : . #

Patch Set 5 : (rebasing) #

Patch Set 6 : Update to r83 #

Patch Set 7 : (rebasing) #

Patch Set 8 : Update to r84 #

Patch Set 9 : Disable the warning 4267 #

Patch Set 10 : Remove duplicated definitions #

Patch Set 11 : Use delta_bi_4.cc instead of delta_bi_32.cc #

Patch Set 12 : (rebasing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/cld_2/cld_2.gyp View 1 2 3 4 5 6 7 8 9 10 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hajimehoshi
Now CLD2 works on Windows. Can you take a look?
7 years, 3 months ago (2013-09-17 01:15:16 UTC) #1
Takashi Toyoshima
Can you split DEPS roll with cld_2.gyp update from changes related to enabling win32? This ...
7 years, 3 months ago (2013-09-17 01:27:58 UTC) #2
hajimehoshi
On 2013/09/17 01:27:58, Takashi Toyoshima (chromium) wrote: > Can you split DEPS roll with cld_2.gyp ...
7 years, 3 months ago (2013-09-17 01:29:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/23463022/70001
7 years, 3 months ago (2013-09-18 01:34:54 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 07:44:27 UTC) #5
Message was sent while issue was closed.
Change committed as 223811

Powered by Google App Engine
This is Rietveld 408576698