Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 23463021: Avoid collapsing anonymous block children already being destroyed (Closed)

Created:
7 years, 3 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Avoid collapsing anonymous block children already being destroyed When normalizing a block with anonymous blocks for first-letter, before content, and contained text, a collapsing anonymous block cascade is triggered that attempts to collapse the contained text's anonymous block within its destruction method. To avoid this, adding logic to bail early if we're already destroying the child anonymous block we're trying to collapse. While in the function, doing a little cleanup to make it more obvious that it only operates on RenderBlocks, not RenderBoxes, and updating some of the comments to hopefully be more useful. BUG=282088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
A + LayoutTests/fast/css-generated-content/normalize-with-first-letter-and-before-content-crash.html View 2 chunks +8 lines, -15 lines 0 comments Download
A + LayoutTests/fast/css-generated-content/normalize-with-first-letter-and-before-content-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 3 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ZZZDONOTUSEMEZZZ
7 years, 3 months ago (2013-09-06 21:07:09 UTC) #1
inferno
lgtm
7 years, 3 months ago (2013-09-06 21:21:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/23463021/1
7 years, 3 months ago (2013-09-06 21:24:41 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 23:40:44 UTC) #4
Message was sent while issue was closed.
Change committed as 157392

Powered by Google App Engine
This is Rietveld 408576698