Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 23463020: Make sure canPlayType does not return probably/maybe for VP9 on Android. (Closed)

Created:
7 years, 3 months ago by Tom Finegan
Modified:
7 years, 3 months ago
Reviewers:
asanka
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Make sure canPlayType does not return probably/maybe for VP9 on Android. BUG=285016 TEST=YouTube playback works for videos that are available in the VP9 format. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221964

Patch Set 1 #

Patch Set 2 : Remove extra blank line.wq #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M net/base/mime_util.cc View 1 2 chunks +8 lines, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
Tom Finegan
Hello Asanka, git cl suggested you as reviewer, so, here you go. PTAL, thanks!
7 years, 3 months ago (2013-09-06 18:01:34 UTC) #1
asanka
lgtm https://codereview.chromium.org/23463020/diff/2001/net/base/mime_util.cc File net/base/mime_util.cc (right): https://codereview.chromium.org/23463020/diff/2001/net/base/mime_util.cc#newcode297 net/base/mime_util.cc:297: // This set of codecs is supported by ...
7 years, 3 months ago (2013-09-06 19:13:32 UTC) #2
Tom Finegan
https://codereview.chromium.org/23463020/diff/2001/net/base/mime_util.cc File net/base/mime_util.cc (right): https://codereview.chromium.org/23463020/diff/2001/net/base/mime_util.cc#newcode297 net/base/mime_util.cc:297: // This set of codecs is supported by all ...
7 years, 3 months ago (2013-09-06 21:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tomfinegan@chromium.org/23463020/2001
7 years, 3 months ago (2013-09-06 21:01:43 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76392
7 years, 3 months ago (2013-09-06 23:41:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tomfinegan@chromium.org/23463020/2001
7 years, 3 months ago (2013-09-08 22:57:50 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-08 23:58:35 UTC) #7
Message was sent while issue was closed.
Change committed as 221964

Powered by Google App Engine
This is Rietveld 408576698