Issue 23462021: Move out Drive cache file path constants outside of file_system_util.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23462021: Move out Drive cache file path constants outside of file_system_util.h. (Closed)

Created:
7 years, 3 months ago by kinaba

Modified:
7 years, 3 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move out Drive cache file path constants outside of file_system_util.h. The path constants are internal implementation details, so they should not be in the publicly used header "file_system_util.h". They were in the common header for sharing the path constants between tests and the production code, but there's no unavoidable reason that tests have to run on that path. BUG=258726 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221996

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -45 lines)			Patch
M	chrome/browser/chromeos/drive/drive_integration_service.cc	View	6 chunks	+21 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_unittest.cc	View	7 chunks	+19 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util.h	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util_unittest.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/23462021/1

7 years, 3 months ago (2013-09-09 07:20:22 UTC) #3

Message was sent while issue was closed.

Change committed as 221996

Expand Messages | Collapse Messages