Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 23462014: InstantExtended: add back focus() API call. (Closed)

Created:
7 years, 3 months ago by samarth
Modified:
7 years, 3 months ago
Reviewers:
jfweitz, kmadhusu
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Jered
Visibility:
Public.

Description

InstantExtended: add back focus() API call. BUG=none TESTED=Open NTP, run chrome.embeddedSearch.searchBox.focus() in the DOM inspector. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220531

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix semi-colon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome/renderer/resources/extensions/searchbox_api.js View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
samarth
Please review. Thanks, Samarth
7 years, 3 months ago (2013-08-29 00:21:17 UTC) #1
jfweitz
LGTM with one nit. You will need a OWNERS stamp. https://codereview.chromium.org/23462014/diff/1/chrome/renderer/resources/extensions/searchbox_api.js File chrome/renderer/resources/extensions/searchbox_api.js (right): https://codereview.chromium.org/23462014/diff/1/chrome/renderer/resources/extensions/searchbox_api.js#newcode47 ...
7 years, 3 months ago (2013-08-29 00:47:52 UTC) #2
samarth
Thanks! I'm in the OWNERS file :) https://codereview.chromium.org/23462014/diff/1/chrome/renderer/resources/extensions/searchbox_api.js File chrome/renderer/resources/extensions/searchbox_api.js (right): https://codereview.chromium.org/23462014/diff/1/chrome/renderer/resources/extensions/searchbox_api.js#newcode47 chrome/renderer/resources/extensions/searchbox_api.js:47: } On ...
7 years, 3 months ago (2013-08-29 00:51:06 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 3 months ago (2013-08-29 00:52:22 UTC) #4
samarth
+kmadhusu
7 years, 3 months ago (2013-08-29 00:54:36 UTC) #5
jfweitz
On 2013/08/29 00:51:06, samarth wrote: > Thanks! > > I'm in the OWNERS file :) ...
7 years, 3 months ago (2013-08-29 00:58:17 UTC) #6
kmadhusu
lgtm
7 years, 3 months ago (2013-08-29 16:56:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samarth@chromium.org/23462014/9001
7 years, 3 months ago (2013-08-29 17:04:18 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 3 months ago (2013-08-29 21:09:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samarth@chromium.org/23462014/9001
7 years, 3 months ago (2013-08-29 21:13:09 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 07:24:53 UTC) #11
Message was sent while issue was closed.
Change committed as 220531

Powered by Google App Engine
This is Rietveld 408576698