Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 23462008: Added LeastUsedAccountDays metric (Closed)

Created:
7 years, 3 months ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Added LeastUsedAccountDays metric BUG=204944 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221686

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added units/sampling info #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Denis Kuznetsov (DE-MUC)
Related changes in ChromeOS : https://chromium-review.googlesource.com/#/c/167340/
7 years, 3 months ago (2013-08-28 17:38:30 UTC) #1
Alexei Svitkine (slow)
https://chromiumcodereview.appspot.com/23462008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://chromiumcodereview.appspot.com/23462008/diff/1/tools/metrics/histograms/histograms.xml#newcode10366 tools/metrics/histograms/histograms.xml:10366: Nit: Add units="days" https://chromiumcodereview.appspot.com/23462008/diff/1/tools/metrics/histograms/histograms.xml#newcode10367 tools/metrics/histograms/histograms.xml:10367: Nit: Mention when this ...
7 years, 3 months ago (2013-08-28 17:41:21 UTC) #2
Denis Kuznetsov (DE-MUC)
On 2013/08/28 17:41:21, Alexei Svitkine wrote: > https://chromiumcodereview.appspot.com/23462008/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (right): > > https://chromiumcodereview.appspot.com/23462008/diff/1/tools/metrics/histograms/histograms.xml#newcode10366 ...
7 years, 3 months ago (2013-08-29 07:56:31 UTC) #3
Alexei Svitkine (slow)
LGTM
7 years, 3 months ago (2013-08-29 14:32:52 UTC) #4
Denis Kuznetsov (DE-MUC)
On 2013/08/29 14:32:52, Alexei Svitkine wrote: > LGTM Please take a look on updated version.
7 years, 3 months ago (2013-08-30 15:18:54 UTC) #5
Alexei Svitkine (slow)
https://chromiumcodereview.appspot.com/23462008/diff/15001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://chromiumcodereview.appspot.com/23462008/diff/15001/tools/metrics/histograms/histograms.xml#newcode5184 tools/metrics/histograms/histograms.xml:5184: + Chrome OS histogram that keeps track of th ...
7 years, 3 months ago (2013-08-30 15:41:05 UTC) #6
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/23462008/diff/15001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://chromiumcodereview.appspot.com/23462008/diff/15001/tools/metrics/histograms/histograms.xml#newcode5184 tools/metrics/histograms/histograms.xml:5184: + Chrome OS histogram that keeps track of th ...
7 years, 3 months ago (2013-08-30 16:42:35 UTC) #7
Alexei Svitkine (slow)
On 2013/08/30 16:42:35, Denis Kuznetsov wrote: > First one is reported only when device is ...
7 years, 3 months ago (2013-08-30 16:50:36 UTC) #8
Denis Kuznetsov (DE-MUC)
On 2013/08/30 16:50:36, Alexei Svitkine wrote: > On 2013/08/30 16:42:35, Denis Kuznetsov wrote: > > ...
7 years, 3 months ago (2013-08-30 17:21:56 UTC) #9
Alexei Svitkine (slow)
lgtm
7 years, 3 months ago (2013-08-30 17:24:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/23462008/23001
7 years, 3 months ago (2013-09-06 11:59:07 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 11:59:34 UTC) #12
Message was sent while issue was closed.
Change committed as 221686

Powered by Google App Engine
This is Rietveld 408576698