FileAPIMessageFilter Security: Minimal patch to fix permissions escalation.

FileAPIMessageFilter Security: Minimal patch to fix permissions escalation.

Per vandebo's suggestion, this is a minimal fix to the security-hole meant
for backporting/merging.

https://codereview.chromium.org/23760004/ is the long-term fix.

BUG=284792
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222143

[tommycli, 2013-09-05 22:27:49]

Actually there's an issue with a test... hold off on reviewing this for a bit...

[tommycli, 2013-09-06 00:21:31]

tsepez: Resolved the test issue. Ready for review.
teravest: You may be able to answer question below.

https://codereview.chromium.org/23461031/diff/4001/content/browser/child_proc...
File content/browser/child_process_security_policy_impl.cc (right):

https://codereview.chromium.org/23461031/diff/4001/content/browser/child_proc...
content/browser/child_process_security_policy_impl.cc:41:
base::PLATFORM_FILE_APPEND |
If Pepper only ever opens files in filesystems of type:
kFileSystemTypeTemporary, then this is unnecessary. teravest, can you comment?

[teravest, 2013-09-06 00:28:23]

Pepper supports PP_FILESYSTEMTYPE_LOCALPERSISTENT, which maps to
fileapi::kFileSystemTypePersistent.

On Thu, Sep 5, 2013 at 6:21 PM,  <tommycli@chromium.org> wrote:
> tsepez: Resolved the test issue. Ready for review.
> teravest: You may be able to answer question below.
>
>
>
https://codereview.chromium.org/23461031/diff/4001/content/browser/child_proc...
> File content/browser/child_process_security_policy_impl.cc (right):
>
>
https://codereview.chromium.org/23461031/diff/4001/content/browser/child_proc...
> content/browser/child_process_security_policy_impl.cc:41:
> base::PLATFORM_FILE_APPEND |
> If Pepper only ever opens files in filesystems of type:
> kFileSystemTypeTemporary, then this is unnecessary. teravest, can you
> comment?
>
> https://codereview.chromium.org/23461031/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tommycli, 2013-09-06 01:33:24]

+kinuko

[kinuko, 2013-09-06 01:39:26]

lgtm - could you cc me on the bug?

[tommycli, 2013-09-09 20:54:05]

tsepez: Ping for OWNER review on minimal patch suitable for backporting.

[Tom Sepez, 2013-09-09 20:58:26]

lgtm

[commit-bot: I haz the power, 2013-09-09 20:58:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/23461031/4001

[commit-bot: I haz the power, 2013-09-10 00:10:12]

Change committed as 222143