Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 23461020: Disabled GetSizeForNewRenderView test as this test fails when forced in compositing mode. (Closed)

Created:
7 years, 3 months ago by Shrikant Kelkar
Modified:
7 years, 3 months ago
Reviewers:
gab, kuan
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disabled GetSizeForNewRenderView test as this test fails when forced in compositing mode. This test fails for dynamic size setting in NavigatePending. Following is comment in the code as reference. // If WebContentsView is resized after RenderWidgetHostView is created but // before pending navigation entry is committed, both RenderWidgetHostView and // WebContentsView use the new size of WebContentsView. BUG=281726 R=gab,kuan TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221146

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed gab's comments. #

Patch Set 3 : Addressed gab's comment and fixed experimental modification. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Shrikant Kelkar
7 years, 3 months ago (2013-09-03 23:18:59 UTC) #1
gab
lgtm if test owners agrees. https://codereview.chromium.org/23461020/diff/1/content/browser/web_contents/web_contents_impl_browsertest.cc File content/browser/web_contents/web_contents_impl_browsertest.cc (right): https://codereview.chromium.org/23461020/diff/1/content/browser/web_contents/web_contents_impl_browsertest.cc#newcode231 content/browser/web_contents/web_contents_impl_browsertest.cc:231: // force-compositing-mode is resolved ...
7 years, 3 months ago (2013-09-03 23:29:27 UTC) #2
kuan
https://codereview.chromium.org/23461020/diff/1/content/browser/web_contents/web_contents_impl_browsertest.cc File content/browser/web_contents/web_contents_impl_browsertest.cc (right): https://codereview.chromium.org/23461020/diff/1/content/browser/web_contents/web_contents_impl_browsertest.cc#newcode34 content/browser/web_contents/web_contents_impl_browsertest.cc:34: #if defined(TOOLKIT_GTK) || defined(OS_MACOSX) one thing u can try ...
7 years, 3 months ago (2013-09-03 23:42:19 UTC) #3
Shrikant Kelkar
https://codereview.chromium.org/23461020/diff/1/content/browser/web_contents/web_contents_impl_browsertest.cc File content/browser/web_contents/web_contents_impl_browsertest.cc (right): https://codereview.chromium.org/23461020/diff/1/content/browser/web_contents/web_contents_impl_browsertest.cc#newcode34 content/browser/web_contents/web_contents_impl_browsertest.cc:34: #if defined(TOOLKIT_GTK) || defined(OS_MACOSX) On 2013/09/03 23:42:20, kuan wrote: ...
7 years, 3 months ago (2013-09-04 00:16:52 UTC) #4
kuan
On 2013/09/04 00:16:52, Shrikant Kelkar wrote: > https://codereview.chromium.org/23461020/diff/1/content/browser/web_contents/web_contents_impl_browsertest.cc > File content/browser/web_contents/web_contents_impl_browsertest.cc (right): > > https://codereview.chromium.org/23461020/diff/1/content/browser/web_contents/web_contents_impl_browsertest.cc#newcode34 ...
7 years, 3 months ago (2013-09-04 00:23:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/23461020/3001
7 years, 3 months ago (2013-09-04 00:30:09 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 04:38:57 UTC) #7
Message was sent while issue was closed.
Change committed as 221146

Powered by Google App Engine
This is Rietveld 408576698