Add support in iossim for recognizing sandboxed system logs.

Add support in iossim for recognizing sandboxed system logs.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222918

[TVL, 2013-09-12 13:56:08]

https://codereview.chromium.org/23460032/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://codereview.chromium.org/23460032/diff/1/testing/iossim/iossim.mm#newc...
testing/iossim/iossim.mm:293: [versionString rangeOfString:@"."].location]
intValue];
[[[versionString componentsSeparatedByString:@"."] firstObject] intValue]

might be a little easy to read (firstObject goes back to 10.6)

https://codereview.chromium.org/23460032/diff/1/testing/iossim/iossim.mm#newc...
testing/iossim/iossim.mm:333: for (NSString* line in lines) {
You have no checks here for if the file doesn't exists.  do you want to fail if
it doesn't exist?  or atleast warn?

https://codereview.chromium.org/23460032/diff/1/testing/iossim/iossim.mm#newc...
testing/iossim/iossim.mm:343: remove([path UTF8String]);
[path fileSystemRepresentation] (but we probably have that wrong in a bunch of
places in here.

[lliabraa, 2013-09-12 16:11:55]

Thanks for the review

https://chromiumcodereview.appspot.com/23460032/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/23460032/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:293: [versionString rangeOfString:@"."].location]
intValue];
On 2013/09/12 13:56:08, TVL wrote:
> [[[versionString componentsSeparatedByString:@"."] firstObject] intValue]
> 
> might be a little easy to read (firstObject goes back to 10.6)

hmm..my compiler didn't like firstObject (and I don't see it here[1]. Used
objectAtIndex:0 instead.

[1]
https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundat...

https://chromiumcodereview.appspot.com/23460032/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:333: for (NSString* line in lines) {
On 2013/09/12 13:56:08, TVL wrote:
> You have no checks here for if the file doesn't exists.  do you want to fail
if
> it doesn't exist?  or atleast warn?

Done.

https://chromiumcodereview.appspot.com/23460032/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:343: remove([path UTF8String]);
On 2013/09/12 13:56:08, TVL wrote:
> [path fileSystemRepresentation] (but we probably have that wrong in a bunch of
> places in here.

Done.

[TVL, 2013-09-12 16:36:44]

lgtm

https://chromiumcodereview.appspot.com/23460032/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/23460032/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:293: [versionString rangeOfString:@"."].location]
intValue];
On 2013/09/12 16:11:55, lliabraa wrote:
> On 2013/09/12 13:56:08, TVL wrote:
> > [[[versionString componentsSeparatedByString:@"."] firstObject] intValue]
> > 
> > might be a little easy to read (firstObject goes back to 10.6)
> 
> hmm..my compiler didn't like firstObject (and I don't see it here[1]. Used
> objectAtIndex:0 instead.
> 
> [1]
>
https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundat...

Ah, you must be using a mac sdk without it protoyped yet.  no worries.

[commit-bot: I haz the power, 2013-09-12 17:21:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/23460032/2001

[commit-bot: I haz the power, 2013-09-12 23:54:27]

Change committed as 222918