Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 23460030: Clean up device policy definitions. (Closed)

Created:
7 years, 3 months ago by Mattias Nissler (ping if slow)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Clean up device policy definitions. In particular: * deprecate obsolete protobuf fields * remove support for Kiosk App update URLs * add missing decoding for http_downloads_enabled BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223041

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -46 lines) Patch
M chrome/app/policy/policy_templates.json View 1 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account.cc View 5 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 1 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_names.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/policy/proto/chromeos/chrome_device_policy.proto View 1 4 chunks +10 lines, -6 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mattias Nissler (ping if slow)
Please review.
7 years, 3 months ago (2013-09-11 16:34:52 UTC) #1
bartfab (slow)
https://chromiumcodereview-hr.appspot.com/23460030/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://chromiumcodereview-hr.appspot.com/23460030/diff/1/chrome/app/policy/policy_templates.json#newcode120 chrome/app/policy/policy_templates.json:120: # For your editing convenience: highest ID currently used: ...
7 years, 3 months ago (2013-09-11 16:44:08 UTC) #2
Mattias Nissler (ping if slow)
https://chromiumcodereview-hr.appspot.com/23460030/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): https://chromiumcodereview-hr.appspot.com/23460030/diff/1/chrome/app/policy/policy_templates.json#newcode120 chrome/app/policy/policy_templates.json:120: # For your editing convenience: highest ID currently used: ...
7 years, 3 months ago (2013-09-12 12:49:12 UTC) #3
xiyuan
LGTM
7 years, 3 months ago (2013-09-12 16:31:48 UTC) #4
bartfab (slow)
lgtm
7 years, 3 months ago (2013-09-12 16:44:59 UTC) #5
Mattias Nissler (ping if slow)
Joao: Friendly ping
7 years, 3 months ago (2013-09-12 16:56:10 UTC) #6
Joao da Silva
lgtm
7 years, 3 months ago (2013-09-12 17:04:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/23460030/1
7 years, 3 months ago (2013-09-13 09:50:39 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/app/policy/policy_templates.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-13 09:50:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/23460030/2
7 years, 3 months ago (2013-09-13 12:05:12 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 14:19:59 UTC) #11
Message was sent while issue was closed.
Change committed as 223041

Powered by Google App Engine
This is Rietveld 408576698