Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 23460026: [Android WebView] Fix async upload (Closed)

Created:
7 years, 3 months ago by boliu
Modified:
7 years, 3 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, no sievers, epenner, aelias_OOO_until_Jul13, joth, kaanb
Visibility:
Public.

Description

[Android WebView] Fix async upload AsyncPixelTransferManager checks for some EGL specific extensions that are available on the device, but was not correctly retrieved by the GLNonOwnedContext. Note that GLNonOwnedContext is only used on android webview, not chrome on android. BUG=287962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222208

Patch Set 1 #

Total comments: 2

Patch Set 2 : GetDispaly once #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M ui/gl/gl_context_android.cc View 1 3 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
Something has come up with gralloc that warrants an in-person discussion. This is trying to ...
7 years, 3 months ago (2013-09-09 16:53:07 UTC) #1
no sievers
lgtm with 1 nit. You will also need to disable the reclaim limit for WebView ...
7 years, 3 months ago (2013-09-09 16:59:23 UTC) #2
boliu
https://codereview.chromium.org/23460026/diff/1/ui/gl/gl_context_android.cc File ui/gl/gl_context_android.cc (right): https://codereview.chromium.org/23460026/diff/1/ui/gl/gl_context_android.cc#newcode58 ui/gl/gl_context_android.cc:58: eglQueryString(eglGetDisplay(EGL_DEFAULT_DISPLAY), EGL_EXTENSIONS); On 2013/09/09 16:59:23, sievers wrote: > use ...
7 years, 3 months ago (2013-09-09 17:49:37 UTC) #3
boliu
+piman for owners
7 years, 3 months ago (2013-09-09 17:50:46 UTC) #4
piman
lgtm
7 years, 3 months ago (2013-09-09 21:08:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/23460026/6001
7 years, 3 months ago (2013-09-09 21:11:14 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 08:25:40 UTC) #7
Message was sent while issue was closed.
Change committed as 222208

Powered by Google App Engine
This is Rietveld 408576698