Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 23460013: Implement InstanceMirror.== in dart2js and InstanceMirror.hashCode in the VM and … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 62e72d972f7711eb73b4d897dd16c1f5324fd459..adef590c0fe46cad91c3577d45dd4602c6b8e0e2 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -283,7 +283,18 @@ class _LocalInstanceMirrorImpl extends _LocalObjectMirrorImpl
identical(_reflectee, other._reflectee);
}
- int get hashCode => _reflectee.hashCode;
+ int get hashCode {
+ // If the reflectee is a double or bignum, use the base hashCode to preserve
+ // the illusion that boxed numbers with the same value are identical. If the
+ // reflectee is a Smi, use the base hashCode because Object.hashCode does
+ // not work for non-heap objects. Otherwise, use Object.hashCode to maintain
+ // correctness even if a user-defined hashCode returns different values for
+ // successive invocations.
+ return _reflectee is num ? _reflectee.hashCode : _identityHash(_reflectee);
+ }
+
+ static _identityHash(reflectee)
+ native "InstanceMirror_identityHash";
_invoke(reflectee, functionName, positionalArguments)
native 'InstanceMirror_invoke';

Powered by Google App Engine
This is Rietveld 408576698