Issue 23460010: Swap force OPUS to iSAC in peerconnection.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23460010: Swap force OPUS to iSAC in peerconnection.html (Closed)

Created:
7 years, 3 months ago by jansson

Modified:
7 years, 3 months ago

Reviewers:
kjellander_chromium, phoglund_chromium

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Swapped force OPUS to iSAC Chrome uses OPUS by default hence it makes sense to force ISAC instead. BUG=279101 NOTRY=TRUE TEST=Manual test verifying that iSAC is used instead of OPUS in chrome://webrtc-internals and that the sound is played back OK. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220550

Patch Set 1 #

Patch Set 2 : fixed ISAC > iSAC #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	chrome/test/data/webrtc/manual/peerconnection.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/test/data/webrtc/manual/peerconnection.js	View		2 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kjellander_chromium

Just make sure to change ISAC->iSAC (http://tools.ietf.org/html/draft-legrand-rtp-isac-02). LGTM

7 years, 3 months ago (2013-08-30 11:15:09 UTC) #2

jansson

On 2013/08/30 11:15:09, Henrik Kjellander wrote: > Just make sure to change ISAC->iSAC > (http://tools.ietf.org/html/draft-legrand-rtp-isac-02). ...

7 years, 3 months ago (2013-08-30 11:17:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jansson@chromium.org/23460010/5001

7 years, 3 months ago (2013-08-30 11:18:21 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages