Handle cache-control:no-store header in PNaCl translation cache

Handle cache-control:no-store header in PNaCl translation cache

Pexe files with the cache-control:no-store header should not be cached.
Add a field to the PnaclCacheInfo struct, plumb the value all the way
from the plugin to the browser, and treat it basically the same way we
currently treat incognito translations (since we currently don't have an
off-the-record cache for those).
R=jvoung@chromium.org
BUG=none, noticed this was missing when doing cleanup

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221275
Reverted due to iterator use-after-erase in patchset 4. fixed in 5. No idea why it passed the CQ so cleanly but blew up the buildbots so completely.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221525

[Derek Schuff, 2013-08-30 21:07:42]

jvoung: everything
jschuh: IPC security
dmichael: chrome/renderer/pepper and ppapi/api

[jvoung (off chromium), 2013-08-30 22:19:09]

lgtm

https://codereview.chromium.org/23458015/diff/1/chrome/browser/nacl_host/pnac...
File chrome/browser/nacl_host/pnacl_host.cc (right):

https://codereview.chromium.org/23458015/diff/1/chrome/browser/nacl_host/pnac...
chrome/browser/nacl_host/pnacl_host.cc:272:
!entry->second.cache_info.has_no_store_header;
Would it be useful to put these checks in a helper function?  Something that
returns (is_incognito || has_no_store_header)?

[dmichael (off chromium), 2013-09-03 19:04:04]

lgtm

https://codereview.chromium.org/23458015/diff/1/components/nacl/common/pnacl_...
File components/nacl/common/pnacl_types.h (right):

https://codereview.chromium.org/23458015/diff/1/components/nacl/common/pnacl_...
components/nacl/common/pnacl_types.h:30: bool has_no_store_header;
should you also add initialization for this in the body file?

[jschuh, 2013-09-03 21:01:03]

ipc security lgtm.

[Derek Schuff, 2013-09-03 22:14:52]

https://codereview.chromium.org/23458015/diff/1/chrome/browser/nacl_host/pnac...
File chrome/browser/nacl_host/pnacl_host.cc (right):

https://codereview.chromium.org/23458015/diff/1/chrome/browser/nacl_host/pnac...
chrome/browser/nacl_host/pnacl_host.cc:272:
!entry->second.cache_info.has_no_store_header;
On 2013/08/30 22:19:09, jvoung (cr) wrote:
> Would it be useful to put these checks in a helper function?  Something that
> returns (is_incognito || has_no_store_header)?

Done.

https://codereview.chromium.org/23458015/diff/1/components/nacl/common/pnacl_...
File components/nacl/common/pnacl_types.h (right):

https://codereview.chromium.org/23458015/diff/1/components/nacl/common/pnacl_...
components/nacl/common/pnacl_types.h:30: bool has_no_store_header;
On 2013/09/03 19:04:05, dmichael wrote:
> should you also add initialization for this in the body file?

Done.

[commit-bot: I haz the power, 2013-09-03 22:15:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/23458015/11001

[commit-bot: I haz the power, 2013-09-03 23:23:20]

Retried try job too often on linux_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-09-04 04:20:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/23458015/25001

[commit-bot: I haz the power, 2013-09-04 05:33:37]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-04 16:32:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/23458015/57001

[commit-bot: I haz the power, 2013-09-04 21:34:35]

Change committed as 221275

[commit-bot: I haz the power, 2013-09-05 19:46:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/23458015/77001

[commit-bot: I haz the power, 2013-09-05 21:46:19]

Change committed as 221525