Issue 23456033: Remove stale heap leak check suppressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23456033: Remove stale heap leak check suppressions. (Closed)

Created:
7 years, 3 months ago by Yang

Modified:
7 years, 3 months ago

Reviewers:
Lei Zhang, Michael Achenbach

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove stale heap leak check suppressions. R=machenbach@chromium.org BUG=246567 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223350

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -68 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View		2 chunks	+0 lines, -68 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yangguo@chromium.org/23456033/1

7 years, 3 months ago (2013-09-16 12:12:09 UTC) #3

Lei Zhang

Umm, you accidentally removed bug_291236_* as well and the bots went red. I will put ...

7 years, 3 months ago (2013-09-16 21:51:08 UTC) #5

Yang

7 years, 3 months ago (2013-09-17 07:39:50 UTC) #6

Message was sent while issue was closed.

On 2013/09/16 21:51:08, Lei Zhang wrote:
> Umm, you accidentally removed bug_291236_* as well and the bots went red. I
will
> put it back...

You are right. I was investigating issue 291236 when I came across the
supression for 246567 and must have mixed things up. Thanks!

Expand Messages | Collapse Messages