Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 23456031: Prevent crash due to XMLDocumentParser destruction (Closed)

Created:
7 years, 3 months ago by pdr.
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Prevent crash due to XMLDocumentParser destruction This patch prevents a crash in XMLDocumentParser::append due to the parser being destructed through doWrite. Destructing the parser can lead to the subsequent isStopped() check to fail to return, but by keeping the parser alive we ensure isStopped() correctly exits. BUG=278908 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157914

Patch Set 1 #

Patch Set 2 : Prevent crash in DocumentLoader::dataReceived #

Patch Set 3 : Rebase for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-17 18:39:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/23456031/6001
7 years, 3 months ago (2013-09-17 18:39:43 UTC) #2
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 19:49:18 UTC) #3
Message was sent while issue was closed.
Change committed as 157914

Powered by Google App Engine
This is Rietveld 408576698