Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 23456019: Fix Windows audio capturer to handle AUDCLNT_BUFFERFLAGS_SILENT flag. (Closed)

Created:
7 years, 3 months ago by Sergey Ulanov
Modified:
7 years, 3 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix Windows audio capturer to handle AUDCLNT_BUFFERFLAGS_SILENT flag. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221585

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/host/audio_capturer_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
I'm not sure if there were any downsides of ignoring this flag, but it's better ...
7 years, 3 months ago (2013-09-05 02:25:55 UTC) #1
alexeypa (please no reviews)
lgtm
7 years, 3 months ago (2013-09-05 16:24:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23456019/3001
7 years, 3 months ago (2013-09-05 18:43:22 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 05:40:20 UTC) #4
Message was sent while issue was closed.
Change committed as 221585

Powered by Google App Engine
This is Rietveld 408576698