[Telemetry] Improve logging on media measurement tests.

tools/perf/metrics/media.py

Index: tools/perf/metrics/media.py
diff --git a/tools/perf/metrics/media.py b/tools/perf/metrics/media.py
index a594ec733db86896e74edaa4b00b7c2e0bde484a..4586a7889ae39a44c86d99560a88d53edf767b85 100644
--- a/tools/perf/metrics/media.py
+++ b/tools/perf/metrics/media.py
@@ -27,6 +27,9 @@ class MediaMetric(Metric):
     """Create the media metrics for all media elements in the document."""
     if hasattr(page.page_set, 'skip_basic_metrics'):
       self._skip_basic_metrics = page.page_set.skip_basic_metrics
+    # Page level attribute overrides page-set one.
+    if hasattr(page, 'skip_basic_metrics'):
+      self._skip_basic_metrics = page.skip_basic_metrics

[dtu, 2013/09/05 19:59:19]

Pages inherit attributes from the page set. So you can just do the page check
only.

[shadi, 2013/09/06 22:22:37]

I wish we knew that earlier :) Thanks!

     tab.ExecuteJavaScript('window.__createMediaMetricsForDocument()')
 
   def Stop(self, page, tab):
@@ -65,7 +68,6 @@ class MediaMetric(Metric):
       return
 
     if not self._skip_basic_metrics:
-      AddOneResult('avg_loop_time', 'sec')
       AddOneResult('buffering_time', 'sec')
       AddOneResult('decoded_audio_bytes', 'bytes')
       AddOneResult('decoded_video_bytes', 'bytes')
@@ -73,5 +75,6 @@ class MediaMetric(Metric):
       AddOneResult('dropped_frame_count', 'frames')
       AddOneResult('time_to_play', 'sec')
 
+    AddOneResult('avg_loop_time', 'sec')
     AddOneResult('seek', 'sec')