Issue 23456012: [Telemetry] Improve logging on media measurement tests.

Issue 23456012: [Telemetry] Improve logging on media measurement tests. (Closed)

Created:
7 years, 3 months ago by shadi

Modified:
7 years, 3 months ago

Reviewers:
anandc, dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Improve logging on media measurement tests. This CL: - adds a seek_label option to media seek action. Seek label is used to name the trace graphs of seek measurements. - makes element ID the default tracing label. - adds page level skip_basic_metrics check to media measurements. - fix buffering_time sec to ms bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221849

Patch Set 1 : #

Patch Set 2 : Make ID label default, and skip_metric optional at page level. #

Patch Set 3 : fix video.html check #

Total comments: 2

Patch Set 4 : check only page level skip_basic_metrics #

Patch Set 5 : fix buffering_time sec to ms bug #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -30 lines)			Patch
M	tools/perf/metrics/media.js	View	1 2 3 4	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/perf/metrics/media.py	View	1 2 3	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tools/perf/page_sets/tough_video_cases/video.html	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/seek.js	View		2 chunks	+16 lines, -14 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/seek.py	View		2 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dtu

lgtm with nit https://chromiumcodereview.appspot.com/23456012/diff/11001/tools/perf/metrics/media.py File tools/perf/metrics/media.py (right): https://chromiumcodereview.appspot.com/23456012/diff/11001/tools/perf/metrics/media.py#newcode32 tools/perf/metrics/media.py:32: self._skip_basic_metrics = page.skip_basic_metrics Pages inherit attributes ...

7 years, 3 months ago (2013-09-05 19:59:19 UTC) #4

shadi

Thanks! https://chromiumcodereview.appspot.com/23456012/diff/11001/tools/perf/metrics/media.py File tools/perf/metrics/media.py (right): https://chromiumcodereview.appspot.com/23456012/diff/11001/tools/perf/metrics/media.py#newcode32 tools/perf/metrics/media.py:32: self._skip_basic_metrics = page.skip_basic_metrics On 2013/09/05 19:59:19, Dave Tu ...

7 years, 3 months ago (2013-09-06 22:22:37 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/23456012/27001

7 years, 3 months ago (2013-09-06 22:30:42 UTC) #6

Message was sent while issue was closed.

Change committed as 221849

Expand Messages | Collapse Messages