Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 23455054: Remove old chromedriver from build/archive. Sources will be removed next. (Closed)

Created:
7 years, 3 months ago by kkania
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Remove old chromedriver from build/archive. Sources will be removed next. This is a revert of the previous try, which broke some chromeos stuff. Since the new ChromeDriver is a drop-in replacement of the old, we'll transition the new one to the old target name, staring in this CL. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223832

Patch Set 1 : unrevert #

Patch Set 2 : change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -270 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 3 chunks +16 lines, -266 lines 0 comments Download
M chrome/tools/build/linux/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/mac/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/TESTS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kkania
Patch set 1: just unrevert Patch set 2: change (rename chromedriver2_server as chromedriver)
7 years, 3 months ago (2013-09-17 19:40:44 UTC) #1
kkania
7 years, 3 months ago (2013-09-17 19:40:49 UTC) #2
sky
LGTM
7 years, 3 months ago (2013-09-17 23:32:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/23455054/17001
7 years, 3 months ago (2013-09-17 23:49:21 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-18 00:02:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/23455054/17001
7 years, 3 months ago (2013-09-18 03:27:03 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 09:37:22 UTC) #7
Message was sent while issue was closed.
Change committed as 223832

Powered by Google App Engine
This is Rietveld 408576698